Add Makefile and Circle CI config #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
tedsuo and
yurishkuro
as code owners
songy23
commented
Aug 9, 2019
.circleci/config.yaml
Outdated
| @@ -0,0 +1,14 @@ | |||
| version: 2 | |||
There was a problem hiding this comment.
I'm less familiar with Circle CI setup so gently paging @rghetia and @pavolloffay for a review.
rghetia
reviewed
Aug 9, 2019
Makefile
Outdated
Fixes open-telemetry#13. Currently the only job is misspell check.
rghetia
approved these changes
Aug 9, 2019
|
@songy23 the failure may be due to filename .circleci.yaml instead of .circleci.yml |
|
@rghetia That fixed it - thanks! |
bogdandrutu
approved these changes
Aug 9, 2019
songy23
added a commit
to songy23/opentelemetry-specification
that referenced
this pull request
Aug 23, 2019
Also update Makefile to build tools locally. Similar to open-telemetry/oteps#14.
songy23
added a commit
to songy23/opentelemetry-specification
that referenced
this pull request
Aug 23, 2019
Also update Makefile to build tools locally. Similar to open-telemetry/oteps#14.
songy23
added a commit
to songy23/opentelemetry-specification
that referenced
this pull request
Aug 23, 2019
Also update Makefile to build tools locally. Similar to open-telemetry/oteps#14.
bogdandrutu
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Aug 23, 2019
Also update Makefile to build tools locally. Similar to open-telemetry/oteps#14.
Oberon00
pushed a commit
to dynatrace-oss-contrib/oteps
that referenced
this pull request
Sep 16, 2019
* Add typed spans working document * Restructuring and scoping - Added motivation - Provided a broader scope and less implementation details, like naming or mandatory fields - Removed tables
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
Also update Makefile to build tools locally. Similar to open-telemetry/oteps#14.
jsuereth
pushed a commit
to jsuereth/otel-semconv-test
that referenced
this pull request
Apr 19, 2023
Also update Makefile to build tools locally. Similar to open-telemetry/oteps#14.
jsuereth
pushed a commit
to open-telemetry/semantic-conventions
that referenced
this pull request
May 11, 2023
Also update Makefile to build tools locally. Similar to open-telemetry/oteps#14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13.
Currently the only job is misspell check.