-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 0008 Metric observer callback specification #39
Merged
yurishkuro
merged 5 commits into
open-telemetry:master
from
jmacd:jmacd/metric_observer
Sep 12, 2019
Merged
RFC 0008 Metric observer callback specification #39
yurishkuro
merged 5 commits into
open-telemetry:master
from
jmacd:jmacd/metric_observer
Sep 12, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
songy23,
tedsuo and
yurishkuro
as code owners
September 4, 2019 07:18
bogdandrutu
reviewed
Sep 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, some small details.
bogdandrutu
approved these changes
Sep 4, 2019
lzchen
reviewed
Sep 5, 2019
LGTM |
lizthegrey
approved these changes
Sep 10, 2019
lzchen
approved these changes
Sep 10, 2019
reyang
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Since this is close to having the approvals it needs, I've allocated RFC number 0008 here. |
jmacd
changed the title
Metric observer callback specification
WIP: RFC 0008 Metric observer callback specification
Sep 11, 2019
tedsuo
approved these changes
Sep 11, 2019
tedsuo
changed the title
WIP: RFC 0008 Metric observer callback specification
RFC 0008 Metric observer callback specification
Sep 12, 2019
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 23, 2024
* Metric observer spec * Observers cannot call use Set. Suggest a constructor name. * Typo fix * Number 0007 * Use 0008
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 23, 2024
* Metric observer spec * Observers cannot call use Set. Suggest a constructor name. * Typo fix * Number 0007 * Use 0008
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 30, 2024
* Metric observer spec * Observers cannot call use Set. Suggest a constructor name. * Typo fix * Number 0007 * Use 0008
carlosalberto
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Nov 8, 2024
…oteps#39) * Metric observer spec * Observers cannot call use Set. Suggest a constructor name. * Typo fix * Number 0007 * Use 0008
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.