Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 0008 Metric observer callback specification #39

Merged
merged 5 commits into from
Sep 12, 2019

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Sep 4, 2019

No description provided.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, some small details.

text/0000-metric-observer.md Outdated Show resolved Hide resolved
text/0000-metric-observer.md Outdated Show resolved Hide resolved
@lzchen
Copy link
Contributor

lzchen commented Sep 5, 2019

LGTM

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jmacd
Copy link
Contributor Author

jmacd commented Sep 11, 2019

Since this is close to having the approvals it needs, I've allocated RFC number 0008 here.

@jmacd jmacd changed the title Metric observer callback specification WIP: RFC 0008 Metric observer callback specification Sep 11, 2019
@yurishkuro yurishkuro merged commit 6cf88c9 into open-telemetry:master Sep 12, 2019
@tedsuo tedsuo changed the title WIP: RFC 0008 Metric observer callback specification RFC 0008 Metric observer callback specification Sep 12, 2019
@jmacd jmacd deleted the jmacd/metric_observer branch September 13, 2019 18:15
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 23, 2024
* Metric observer spec

* Observers cannot call use Set. Suggest a constructor name.

* Typo fix

* Number 0007

* Use 0008
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 23, 2024
* Metric observer spec

* Observers cannot call use Set. Suggest a constructor name.

* Typo fix

* Number 0007

* Use 0008
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 30, 2024
* Metric observer spec

* Observers cannot call use Set. Suggest a constructor name.

* Typo fix

* Number 0007

* Use 0008
carlosalberto pushed a commit to open-telemetry/opentelemetry-specification that referenced this pull request Nov 8, 2024
…oteps#39)

* Metric observer spec

* Observers cannot call use Set. Suggest a constructor name.

* Typo fix

* Number 0007

* Use 0008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants