-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change http.request.body.size
and http.response.body.size
attributes from recommended to opt-in
#460
Change http.request.body.size
and http.response.body.size
attributes from recommended to opt-in
#460
Conversation
80a2729
to
98c964e
Compare
…from recommended to opt-in
98c964e
to
f12e1e3
Compare
@trask I think you need to regenrate the tables |
I guess we should then consider doing the same for messaging ( |
I opened #474 to discuss/track |
Fixes #456
Changes
There are a few concerns with
http.request.body.size
andhttp.response.body.size
:Content-Length
header which can already be captured ashttp.request.header.content-length
andhttp.response.header.content-length
Content-Length
is not always available, and actual bytes read could be different anyways if the request/response was cancelled.This PR does two things:
experimental
, along with a comment not to mark them stable when we mark the other HTTP attributes as stable next weekI will send a separate PR to propose changes to the definition of these attributes based on the other concerns above.
Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.