Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autopep8 #686

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add autopep8 #686

wants to merge 1 commit into from

Conversation

DabenW
Copy link

@DabenW DabenW commented Jun 2, 2023

  • I have read the note above about PRs contributing or fixing extensions
  • I have tried reaching out to the extension maintainers about publishing this extension to Open VSX (if not, please create an issue in the extension's repo using this template).
  • This extension has an OSI-approved OSS license (we don't accept proprietary extensions in this repository)

Description

This PR introduces autopep8 for python project

@DabenW DabenW changed the title Added Add autopep8 Jun 2, 2023
@DabenW
Copy link
Author

DabenW commented Jun 13, 2023

@filiptronicek Can you take a look at this PR

@filiptronicek
Copy link
Collaborator

filiptronicek commented Jun 13, 2023

Packaging seems to be succeeding, but it looks like we're missing something:

Our .vsix Microsoft-published .vsix
154 KB 631 KB
ms-python.autopep8-2023.4.0.zip ms-python.autopep8.zip

@filiptronicek filiptronicek self-assigned this Jun 13, 2023
@filiptronicek filiptronicek added the extension Regarding an extension label Jun 13, 2023
@filiptronicek filiptronicek added the changes-requested Waiting for an update label Aug 8, 2023
@cavcrosby
Copy link

@filiptronicek could it be what you're seeing is due to a different Python version being used for validation (you seem to have run into this here #659 (review))?

@apollo13
Copy link
Contributor

apollo13 commented Sep 8, 2023

I think the size difference might be due to the missing custom commands: https://github.com/open-vsx/publish-extensions/pull/704/files#diff-67cc6b3a3e8789d9c898df808bc20c696365e6356a7ecc49d28cdb7e5b43a566R795 -- the required commands can be seen in https://github.com/microsoft/vscode-autopep8/blob/main/.github/actions/build-vsix/action.yml

@jeanp413
Copy link
Collaborator

ping @filiptronicek

@bn-d bn-d mentioned this pull request Dec 20, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-requested Waiting for an update extension Regarding an extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants