feat: add capability to attach the supported modules #501
Conversation
In previous the recent update it was not possible to conditionaly attach the module. With this PR it would be possible to attach the compatible modules depending on the file types.
Also update the moduleApiVersion across the project
Having a module varible can be a landmine in case we accidently do not declare module in args, then it will pick the common js module keyword.
- make CHANGELOG more detailed - remove redundant tests - make constructor compact
|
Prettier is failing on your MR, can you fix it ? |
|
Sure, looking into it. |
|
What are your thoughts on using git hooks to fix the linting before commit/push? If you are okay I can open an issue. I personally use husky for this. |
|
The prettier errors are fixed but |
|
The failure on travis is expected, since you don't have the access keys to travis. The check casing verifies that all files use lowercase names and don't contain |
harish-aka-shivi
changed the title
|
Hey, |
|
I've now merged your PR @harish-aka-shivi ! check-casing uses a lot of builtin commands that work on linux, probably some of them differ on macosx. You could add set -x just below set -euo pipefail to see the last command that was executed, probably it fails because of a mac/unix difference. |
|
Yup, Surely I will try that |
Description
In the recent update of Docxtemplater version, it was not possible to conditionally attach the module. With this PR, only the compatible modules will be attached while constructing Docxtemplater instance.
closes #499