Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: support versions 1.22 and 1.23 of the Go compiler #951

Merged
merged 33 commits into from
Sep 13, 2024
Merged

Conversation

zapateo
Copy link
Member

@zapateo zapateo commented Sep 5, 2024

Commit Message

all: support versions 1.22 and 1.23 of the Go compiler

This commit ensures that Scriggo supports the Go compiler in versions
1.22 and 1.23.

Support for compiler versions 1.21 and earlier is therefore no longer
guaranteed.

Regarding support related to the language itself and the changes
introduced by the various versions of Go, we have opened a dedicated
issue (#952), which tracks the various changes in Scriggo's behavior to
align with the behaviors introduced in Go version 1.19 and subsequent
versions up to 1.23; therefore, some tests have been disabled while we
await support for specific changes recently introduced in Go.

TODO

  • Make the tests pass again (even if some of them are skipped on the branch)
  • Aprire issue elencando tutte le cose "aggiuntive" per supportare le versioni nuovi (builtin, comportamenti, etc...)
  • Fix the skipped tests
  • Update the version in the GitHub action to use the version 1.23 of Go
  • Aggiornare golang.org/x/mod alla latest, non la 20, c'è la 21
  • Update the documentation. Do a branch on the documentation repository. → We'll do that on the release of the next version of Scriggo, not when merging this PR
  • Skip general types
  • Capire se e come va modificata la funzione stdLibPaths dentro il file cmd/scriggo/main.go (@gazerro)
  • Test with both Go 1.22 and 1.23 (@gazerro)

@zapateo zapateo marked this pull request as draft September 5, 2024 14:37
@zapateo zapateo mentioned this pull request Sep 5, 2024
2 tasks
@zapateo zapateo changed the title Support Go 1.22 and 1.23 all: support version 1.22 and 1.23 of the Go compiler Sep 6, 2024
@zapateo zapateo changed the title all: support version 1.22 and 1.23 of the Go compiler all: support versions 1.22 and 1.23 of the Go compiler Sep 6, 2024
@zapateo zapateo marked this pull request as ready for review September 6, 2024 14:40
@zapateo zapateo requested a review from gazerro September 6, 2024 14:41
Copy link
Member

@gazerro gazerro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip general types, including general interfaces.

cmd/scriggo/generate.go Outdated Show resolved Hide resolved
cmd/scriggo/generate.go Outdated Show resolved Hide resolved
cmd/scriggo/generate_go1.23_test.go Outdated Show resolved Hide resolved
cmd/scriggo/main.go Outdated Show resolved Hide resolved
@zapateo zapateo merged commit d34d346 into main Sep 13, 2024
@zapateo zapateo deleted the support-1.22-1.23 branch September 13, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants