Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pairsamtools merge single file no action? #38

Closed
sergpolly opened this issue Jul 13, 2017 · 1 comment
Closed

pairsamtools merge single file no action? #38

sergpolly opened this issue Jul 13, 2017 · 1 comment

Comments

@sergpolly
Copy link
Member

Wouldn't it be a good approach not to do anything with an input file, in case pairsamtools merge is provided with only a single file ?

  • Right now it's up to distiller to check if it's a single-file input. Single files are treated differently - they're copied by distiller and are left untouched.

  • pairsamtools merge however does something to the pairsam header, even if it's just a single file and there is nothing to merge. Modified headers cause downstream issues in case of hierarchical merge implemented in distiller. Dealing with that in pairsamtools merge would make distiller code cleaner.

@golobor
Copy link
Member

golobor commented Sep 9, 2017

done!

@golobor golobor closed this as completed Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants