Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add structure of variable section and import nomenclature from IAMC 1.5°C #12

Merged
merged 6 commits into from
Mar 27, 2020

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Mar 23, 2020

This PR adds the structure for the variable and unit dimensions. It also creates a first set of codelists (lists of variables) from the IPCC SR15.

To-dos:

  • define structure for variables and draft READMEs in subfolders
  • import relevant nomenclature used for the IPCC SR15, see the docs of the IAMC 1.5°C Scenario Explorer
  • add raw list of variables from IAMC 1.5°C scenario ensemble to variable/data subfolder
  • add processing scripts used to generate yaml files in this PR
  • define structure for units

closes #4

@danielhuppmann danielhuppmann added structure Definition of the repository structure definitions Additions to (or suggestions for) the codelists labels Mar 23, 2020
@danielhuppmann danielhuppmann self-assigned this Mar 23, 2020
@sandrinecharousset
Copy link
Collaborator

The structure of folders looks relevant.
the readme's and yaml look sufficient and are understandable even by a non specialist such as myself.

@sandrinecharousset
Copy link
Collaborator

Units in the description of variables : a unit is mentioned for all variables, where it may appen than different units can be widely used by different communities. One example is energy. In the current description, the unit is EJ (hexaJoule), while usually energy modellers (from the field I am attached to) use MW/MWh/GW/GWh (MegaWatt, MegaWatt-hour, GigaWatt, GigaWatt-hour). There exist an easy conversion (1Wh=3600J) but the magnitudes of main variables are well known by modellers, with their unit only (energy in EJ doesn't speak to me while energy in GWh does). Can we link a serie of recommended units to each variable? Knowing that in the end the unit is in each line of the data.

@danielhuppmann
Copy link
Member Author

thank you for the good comment @sandrinecharousset!

Can we link a serie of recommended units to each variable?

There are several options:

  1. allow a list of (recommended) units for each variable (as long as they are the same type, e.g., energy)
    1. store the data as uploaded by the teams on the platform (potentially making it difficult to compare across models)
    2. convert units during upload to one standard unit (meaning that data displayed and downloaded will have a different unit that what is uploaded by the modelling team)
  2. only allow a specific unit for each variable

We plan to have a feature for unit-conversion in the Scenario Explorer display, but this will probably not be ready before autumn 2020.

@sandrinecharousset
Copy link
Collaborator

Can we link a serie of recommended units to each variable?

There are several options:

  1. allow a list of (recommended) units for each variable (as long as they are the same type, e.g., energy)
    1. store the data as uploaded by the teams on the platform (potentially making it difficult to compare across models)
    2. convert units during upload to one standard unit (meaning that data displayed and downloaded will have a different unit that what is uploaded by the modelling team)
  1. only allow a specific unit for each variable
    => but how to decide which one?

We plan to have a feature for unit-conversion in the Scenario Explorer display, but this will probably not be ready before autumn 2020.

=>My personal feeling is that whenever it is possible to get a compromise on units we should target to have one onIy but it may be difficult not to keep a (short) list of variables with 2 units ( eg the EJ vs GWh). Probably when it is about units that are very close (GW/MW) it will be easy to chose only one, but when it is units that may change the understanding of the data (which shouldn't be numerous), it may be impossible.... The unit-conversion feature above proably solves all this, so if it has to be only temporary maybe we can work with 1 unit for all variables (but which one?)

Copy link
Collaborator

@erikfilias erikfilias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure looks well and easy to understand.

Nonetheless, I have a doubt about declaring the maximum capacity of a pumped-storage hydropower plant. It could be as:
Maximum Capacity|Secondary Energy|Electricity|Hydro|Pumped Storage|Power Plant 1
Where the Maximum Capacity is a variable that belongs to Power Plant 1 and this plant is a pumped-storage hydropower plant.

@arght
Copy link
Collaborator

arght commented Mar 25, 2020

Sandrine,
About regions it depends how flexible we want to be. Allowing intermediate regions introduces flexibility but again may introduce difficulty in the use of the data set, because there can be several definitions of what it Italy North and Italy South. Alternatively, we can use just two NUTS1 from Italy to represent what you want Italy North and Italy South
Best regards
Andrés

@danielhuppmann
Copy link
Member Author

Thank you @sandrinecharousset and @arght for your comments on additional sub-country regions - however, that discussion should not be part of this PR (which is about variables). Instead, @sandrinecharousset, can you please start a new issue to discuss?

@danielhuppmann
Copy link
Member Author

Responding to @erikfilias:

maximum capacity of a pumped-storage hydropower plant
Maximum Capacity|Secondary Energy|Electricity|Hydro|Pumped Storage|Power Plant 1

Yes, in principle that is how this could be added - but a few considerations and comparison to the IAMC 1.5°C variable list (see here), where a similar variable is called.

Capacity|Electricity|Hydro

  1. Having both Secondary Energy and Electricity is redundant for this type of information (there is no electricity of final energy of a hydro plant), so it can be omitted
  2. Maximum Capacity is not clear in the context of a pumped-hydro storage plant - is it storage capacity (reservoir), generation capacity, or pumping capacity?
  3. For other power plants, "maximum" generation capacity is redundant in the usual terms (that's why we only used Capacity in the IAMC 1.5°C context).

So in short, I would suggest to use this more concise version:

  • Capacity|Electricity|Hydro|Pumped Storage|Power Plant 1 for maximum generation capacity
  • Reservoir Capacity|Electricity|Hydro|Pumped Storage|Power Plant 1 for reservoir capacity
  • ...

@arght
Copy link
Collaborator

arght commented Mar 25, 2020

Daniel,
It is true that we need to differentiate between generation capacity and pumping capacity and between minimum capacity and maximum capacity, all of them power in MW/GW.
Another question is size of the hydro or pumped-storage hydro reservoir that it can be in GWh or hm3 depending on the model. I think that FANSI probably will use hm3 but many other models will use GWh/TWh
Andrés

@IngeborgGraabak
Copy link

About the regions definition: from the readme seems we cannot have intermediates between countries and nuts1 regions. in plan4res we use for one country (italy) aggregates which are inbetween (italy separated in ITN and ITS, for noth italy and south italy). Can we give the possibility of having other regionalisations than nuts?

I see your point. But Nuts are clearly defined. In case we are going to use north italy and south italy, we have to define them

@danielhuppmann
Copy link
Member Author

Thanks @arght for raising this valid concern about variables where the "normal" unit depends on the model context. Since this is not directly related to either the folder/file structure or the list of variables used in IAMC 1.5°C scenario ensemble, I have started a new issue (#14) for that discussion.

@danielhuppmann danielhuppmann removed the request for review from tburandt March 27, 2020 18:23
@danielhuppmann
Copy link
Member Author

As discussed in the telco earlier today, I am merging this PR because there are no objections to the folder and file structure. Open discussions in this discussion thread have been moved to specific issues.

@danielhuppmann danielhuppmann merged commit 06f009d into openENTRANCE:master Mar 27, 2020
@danielhuppmann danielhuppmann deleted the defs/variable branch March 27, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
definitions Additions to (or suggestions for) the codelists structure Definition of the repository structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define structure for variables & units and import nomenclature from IAMC 1.5°C
5 participants