-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add structure of variable section and import nomenclature from IAMC 1.5°C #12
Add structure of variable section and import nomenclature from IAMC 1.5°C #12
Conversation
The structure of folders looks relevant. |
Units in the description of variables : a unit is mentioned for all variables, where it may appen than different units can be widely used by different communities. One example is energy. In the current description, the unit is EJ (hexaJoule), while usually energy modellers (from the field I am attached to) use MW/MWh/GW/GWh (MegaWatt, MegaWatt-hour, GigaWatt, GigaWatt-hour). There exist an easy conversion (1Wh=3600J) but the magnitudes of main variables are well known by modellers, with their unit only (energy in EJ doesn't speak to me while energy in GWh does). Can we link a serie of recommended units to each variable? Knowing that in the end the unit is in each line of the data. |
thank you for the good comment @sandrinecharousset!
There are several options:
We plan to have a feature for unit-conversion in the Scenario Explorer display, but this will probably not be ready before autumn 2020. |
=>My personal feeling is that whenever it is possible to get a compromise on units we should target to have one onIy but it may be difficult not to keep a (short) list of variables with 2 units ( eg the EJ vs GWh). Probably when it is about units that are very close (GW/MW) it will be easy to chose only one, but when it is units that may change the understanding of the data (which shouldn't be numerous), it may be impossible.... The unit-conversion feature above proably solves all this, so if it has to be only temporary maybe we can work with 1 unit for all variables (but which one?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structure looks well and easy to understand.
Nonetheless, I have a doubt about declaring the maximum capacity of a pumped-storage hydropower plant. It could be as:
Maximum Capacity|Secondary Energy|Electricity|Hydro|Pumped Storage|Power Plant 1
Where the Maximum Capacity is a variable that belongs to Power Plant 1 and this plant is a pumped-storage hydropower plant.
Sandrine, |
Thank you @sandrinecharousset and @arght for your comments on additional sub-country regions - however, that discussion should not be part of this PR (which is about variables). Instead, @sandrinecharousset, can you please start a new issue to discuss? |
Responding to @erikfilias:
Yes, in principle that is how this could be added - but a few considerations and comparison to the IAMC 1.5°C variable list (see here), where a similar variable is called.
So in short, I would suggest to use this more concise version:
|
Daniel, |
I see your point. But Nuts are clearly defined. In case we are going to use north italy and south italy, we have to define them |
Thanks @arght for raising this valid concern about variables where the "normal" unit depends on the model context. Since this is not directly related to either the folder/file structure or the list of variables used in IAMC 1.5°C scenario ensemble, I have started a new issue (#14) for that discussion. |
As discussed in the telco earlier today, I am merging this PR because there are no objections to the folder and file structure. Open discussions in this discussion thread have been moved to specific issues. |
This PR adds the structure for the
variable
andunit
dimensions. It also creates a first set of codelists (lists of variables) from the IPCC SR15.To-dos:
variable/data
subfolderyaml
files in this PRcloses #4