Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return the error if no field selected #505

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

MrSanZhi
Copy link
Member

What is changed and how it works?

When querying fields that are not found in lookkeeper, an error will be reported, and the missing fields will be prompted in the error.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B
  • Test cases to be added
  • No code

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@MrSanZhi MrSanZhi force-pushed the process_error branch 3 times, most recently from 2d96d83 to 787709d Compare February 28, 2024 10:45
Signed-off-by: Jack Liu <1758975670@qq.com>
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.73%. Comparing base (502f6cd) to head (acec452).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #505      +/-   ##
==========================================
- Coverage   74.75%   74.73%   -0.02%     
==========================================
  Files         558      558              
  Lines      118218   118218              
==========================================
- Hits        88369    88349      -20     
- Misses      24344    24364      +20     
  Partials     5505     5505              

@xiangyu5632 xiangyu5632 merged commit 12964c4 into openGemini:main Feb 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants