Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scan): quick cancel query with proactive manager #506

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

MrSanZhi
Copy link
Member

What is changed and how it works?

When the memory exceeds a certain threshold, the crash method is used to quickly interrupt the query and push each executor to exit quickly.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B
  • Test cases to be added
  • No code

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@MrSanZhi MrSanZhi force-pushed the proactive_manager branch 3 times, most recently from df8ce72 to 3ef845f Compare February 28, 2024 10:48
Signed-off-by: Jack Liu <1758975670@qq.com>
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 74.74%. Comparing base (502f6cd) to head (3cd271c).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
- Coverage   74.75%   74.74%   -0.01%     
==========================================
  Files         558      558              
  Lines      118218   118297      +79     
==========================================
+ Hits        88369    88426      +57     
- Misses      24344    24365      +21     
- Partials     5505     5506       +1     

Copy link
Member

@xiangyu5632 xiangyu5632 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

engine/column_store_reader.go:373 ,need

err = r.initReadCursor(ctx)

@xiangyu5632 xiangyu5632 merged commit eb39829 into openGemini:main Feb 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants