Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared preferences base classes implemented #12

Merged
merged 1 commit into from
Jun 17, 2021
Merged

shared preferences base classes implemented #12

merged 1 commit into from
Jun 17, 2021

Conversation

danishjamal104
Copy link
Collaborator

Below are some of the major changes this PR includes

  • Added BasePreferenceManager.kt abstract class consisting of the basic structure to be used for managing app preferences.
  • Added concrete UserPreferences.kt class extending the BasePreferenceManager, which consist al the user related preferences methods. (This class is created in reference with PrefManager.java defined in android-client project)
  • Added PORT variable in BaseUrl.kt, refrenced from BaseUrl.java in android-client project.
  • Added new dependency com.google.truth:truth:1.1.3, checkout here.
  • Added instrument test for testing user preferences class.(It uses the above truth dependency).

@danishjamal104 danishjamal104 added the priority Address this on priority label Jun 13, 2021
@danishjamal104
Copy link
Collaborator Author

any update on this @Grandolf49 , @iamsh4shank ??

.gitignore modified

compiler.xml removed
@danishjamal104 danishjamal104 changed the base branch from master to dev-1.5.0 June 17, 2021 00:31
@danishjamal104 danishjamal104 merged commit 3a2f0eb into openMF:dev-1.5.0 Jun 17, 2021
@danishjamal104 danishjamal104 deleted the development-1.5.0 branch June 17, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC 2021 priority Address this on priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant