feat: Third Party Beneficiaries Integration #312
Conversation
| @Override | ||
| public void detachView() { | ||
| super.detachView(); | ||
| subscription.unsubscribe(); |
There was a problem hiding this comment.
@dilpreet96 use subscription.clear() instead
| @Override | ||
| public void detachView() { | ||
| super.detachView(); | ||
| subscription.unsubscribe(); |
There was a problem hiding this comment.
@dilpreet96 use subscription.clear() instead
| @Override | ||
| public void detachView() { | ||
| super.detachView(); | ||
| subscription.unsubscribe(); |
There was a problem hiding this comment.
@dilpreet96 use subscription.clear() instead
| private List<Beneficiary> beneficiaryList; | ||
|
|
||
| @Inject | ||
| public BeneficiaryListAdapter(@ActivityContext Context context) { |
There was a problem hiding this comment.
Good job for using @ActivityContext Context context
| public class ViewHolder extends RecyclerView.ViewHolder { | ||
|
|
||
| @BindView(R.id.tv_beneficiary_name) | ||
| TextView tvName; |
There was a problem hiding this comment.
Give one line space between this and below variable
| public class BeneficiaryDetailFragment extends BaseFragment implements BeneficiaryDetailView { | ||
|
|
||
| @BindView(R.id.tv_beneficiary_name) | ||
| TextView tvName; |
| OnItemClickListener, SwipeRefreshLayout.OnRefreshListener, BeneficiariesView { | ||
|
|
||
| @BindView(R.id.rv_beneficiaries) | ||
| RecyclerView rvBeneficiaries; |
|
|
||
| void showUserInterface(); | ||
|
|
||
| public void showBeneficiaryTemplate(BeneficiaryTemplate beneficiaryTemplate); |
There was a problem hiding this comment.
interface method by default are public, I don't think So you need to mention.
|
|
||
| public interface BeneficiaryDetailView extends MVPView { | ||
|
|
||
| public void showUserInterface(); |
There was a problem hiding this comment.
interface method by default are public, I don't think So you need to mention.
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:layout_margin="@dimen/default_margin"> | ||
| <ScrollView |
There was a problem hiding this comment.
@dilpreet96 please use NestedScrollView
|
@therajanmaurya changes made |
Demo:
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.