Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New debuggables #157

Merged
merged 3 commits into from
Feb 5, 2023
Merged

New debuggables #157

merged 3 commits into from
Feb 5, 2023

Conversation

pvmm
Copy link
Contributor

@pvmm pvmm commented Feb 4, 2023

Debbuger getting ready to use the latest changes in OpenMSX (openMSX/openMSX#1486)

@pvmm pvmm force-pushed the new-debuggables branch 2 times, most recently from 8491c69 to cec6ff1 Compare February 4, 2023 02:12
@pvmm pvmm marked this pull request as ready for review February 4, 2023 02:16
m9710797
m9710797 reviewed Feb 4, 2023
View reviewed changes
Copy link
Contributor

@m9710797 m9710797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this code is correct.
But I have some suggestions for possible improvements.
Some of these are personal preference. Feel free to apply or ignore those.
Thanks!

src/DebuggerForm.cpp Show resolved Hide resolved
src/VDPDataStore.cpp Outdated Show resolved Hide resolved
src/VDPDataStore.cpp Outdated Show resolved Hide resolved
src/VDPDataStore.h Outdated Show resolved Hide resolved
src/VDPDataStore.cpp Outdated Show resolved Hide resolved
src/VDPRegViewer.cpp Outdated Show resolved Hide resolved
src/VDPRegViewer.cpp Outdated Show resolved Hide resolved
src/VDPRegViewer.cpp Outdated Show resolved Hide resolved
src/VDPRegViewer.cpp Outdated Show resolved Hide resolved
src/VDPRegViewer.cpp Show resolved Hide resolved
m9710797
m9710797 reviewed Feb 4, 2023
View reviewed changes
Copy link
Contributor

@m9710797 m9710797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This commit is fine.
I made a comment about a possible future cleanup.

src/TileViewer.cpp Show resolved Hide resolved
m9710797
m9710797 reviewed Feb 4, 2023
View reviewed changes
Copy link
Contributor

@m9710797 m9710797 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating VDPRegViewer and UI

Fine. Thanks!

This was referenced Feb 5, 2023
Open
Open
@pvmm pvmm marked this pull request as draft February 5, 2023 13:33
@pvmm pvmm marked this pull request as ready for review February 5, 2023 13:36
@pvmm pvmm marked this pull request as draft February 5, 2023 13:50
@pvmm pvmm marked this pull request as ready for review February 5, 2023 13:52
@m9710797 m9710797 merged commit 51e7f51 into openMSX:master Feb 5, 2023
@m9710797
Copy link
Contributor

m9710797 commented Feb 5, 2023

Thanks!

@pvmm pvmm deleted the new-debuggables branch February 6, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m9710797 m9710797 m9710797 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvmm @m9710797