-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake Superbuild: Tarball #1668
Conversation
130e38a
to
6e91a44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reducing the configure time by a factor of almost five is significant so an obvious improvement.
Just a small disadvantage. One has to remember to update two lines if the version of a dependency should be updated instead of one.
We are working on a wrapper for FetchContent_Declare
to add a few features which should improve usability if the SOURCE_DIR
directory is defined. We want to reduce the amount of downloads. If you are interested we could discuss this separately.
Thanks! That sounds very interesting as a follow-up, happy to take a look on what you are working on 👍
I would not wait for this extra update for the |
@@ -44,6 +55,14 @@ set(openPMD_catch_src "" | |||
CACHE PATH | |||
"Local path to Catch2 source directory (preferred if set)") | |||
|
|||
# tarball fetcher | |||
set(openPMD_catch_tar "https://github.com/catchorg/Catch2/archive/refs/tags/v2.13.10.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will openPMD_catch_branch
, openPMD_catch_repo
and openPMD_catch_src
be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will support both. The order now of precedence is:
- src
- tar, or if
openPMD_catch_tar
is set to off/false/empty/etc. - git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs added that explain the precedence.
Cloning whole repos can be quite slow and CMake does not support shallow clones yet. We can use release tarballs instead.
6e91a44
to
761f136
Compare
Cloning whole repos can be quite slow and CMake does not support shallow clones yet. We can use release tarballs instead.
Follow-up to #1583
Configure from scratch time:
Todo list: