Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use Mermaid #237

Merged
merged 3 commits into from
Aug 10, 2024
Merged

feat: use Mermaid #237

merged 3 commits into from
Aug 10, 2024

Conversation

nick-cjyx9
Copy link
Contributor

@nick-cjyx9 nick-cjyx9 commented Aug 8, 2024

Solve #213

About this PR:

  • Add remarkMermaid extension to transform mermaid block to <pre>
  • Support render Mermaid in /feed and /writing page with dark & light modes.

Some Problem:

  • Stump during rendering on writing page (in an acceptable level)

  • I haven't deploy it to production env yet.

  • When switch dark & light modes, the Mermaid render will raise Sytax Text Error, but after refreshing the page, the error disappers.

pr_compressed.mp4

@nick-cjyx9 nick-cjyx9 marked this pull request as draft August 8, 2024 07:02
@nick-cjyx9 nick-cjyx9 changed the title feat: use Mermaid #213 feat: use Mermaid Aug 8, 2024
@nick-cjyx9 nick-cjyx9 marked this pull request as ready for review August 8, 2024 08:31
@nick-cjyx9
Copy link
Contributor Author

Is there anyone willing to test these in production env?

Copy link
Collaborator

@OXeu OXeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OXeu OXeu merged commit 7bdaf76 into openRin:main Aug 10, 2024
OXeu added a commit that referenced this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants