Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chroot support #33

Merged
merged 4 commits into from
Dec 18, 2015
Merged

Chroot support #33

merged 4 commits into from
Dec 18, 2015

Conversation

jreidinger
Copy link
Member

tested manually only as it require root permissions for chrooting.

@jreidinger
Copy link
Member Author

coverage decrease again caused by bad detection of code after fork

@@ -226,6 +227,15 @@ Dir.chdir("/workspace") do
end
```

### Changing System Root

If command have to be run on different system root, then :chroot options
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um, I'd suggest better wording:

If a command needs to be executed in a different system root then the `:chroot` option can be used:

@ancorgs
Copy link
Member

ancorgs commented Dec 18, 2015

LGTM

@lslezak
Copy link
Member

lslezak commented Dec 18, 2015

LGTM, thanks!

jreidinger added a commit that referenced this pull request Dec 18, 2015
@jreidinger jreidinger merged commit c917969 into master Dec 18, 2015
@jreidinger jreidinger deleted the chroot_support branch December 18, 2015 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants