Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating nested symlinks (at least by default) [sf#228] #227

Closed
tomschr opened this issue Mar 3, 2015 · 1 comment
Closed

Avoid creating nested symlinks (at least by default) [sf#228] #227

tomschr opened this issue Mar 3, 2015 · 1 comment
Assignees

Comments

@tomschr
Copy link
Collaborator

tomschr commented Mar 3, 2015

Reported by sknorr on 2014-07-01 10:33 UTC
We now have some symlinks in the static/ directories for our HTML output (to avoid duplicating too many files). In the current default setting, this means DAPS creates nested symlinks when building html books, e.g. with:

$ daps -d DC-example html

This can only be avoided by doing

$ daps -d DC-example html --static

Nested symlinks are not a problem per se, but they introduce various resolution issues in both Firefox and Chrome.

So, there would be two possible resolutions to this bug:

  1. Always enable the behaviour of --static (and, if really really necessary add an option --nostatic).
  2. When building the static directory, resolve the links in all files first, and then symlink the original files

Option 1 almost seems like the better option to me, as it avoids any ambiguities in references[1].


[1] as an example for an ambiguous reference: e.g.

  • page.html loads style.css,
  • style.css itself is a symlink to ../../otherfolder/real.css and
  • style.css tries to load image.png

Question: Where should the browser search for image.png? in the current folder or in ../../otherfolder?

@tomschr
Copy link
Collaborator Author

tomschr commented Mar 3, 2015

Commented by sknorr on 2014-08-19 16:33

  • Description has changed:

Diff:


--- old
+++ new
@@ -9,8 +9,9 @@
 Nested symlinks are not a problem per se, but they introduce various resolution issues in both [Firefox](https://bugzilla.mozilla.org/show_bug.cgi?id=symlink) and Chrome.

 So, there would be two possible resolutions to this bug:
-1) Always enable the behaviour of --static (and, if really really necessary add an option --nostatic).
-2) When building the static directory, resolve the links in all files first, and then symlink the original files
+
+1. Always enable the behaviour of --static (and, if really really necessary add an option --nostatic).
+1. When building the static directory, resolve the links in all files first, and then symlink the original files

 Option 1 almost seems like the better option to me, as it avoids any ambiguities in references[1].


  • assigned_to: Frank Sundermeyer
  • Info Provider: Stefan Knorr

fsundermeyer added a commit that referenced this issue Apr 9, 2015
Solves issue #227. Introduced a new option --nostatic to create links as
before. When using --static a deprectation warining is issued.
tomschr added a commit that referenced this issue Apr 14, 2015
- Full support for DocBook 5 now (finally)
- Moved DAPS user config directory to ~/.config/daps/. The config file
  has been renamed to dapsrc (the user will be notified and DAPS will
  automatically do the move if the user agrees)
- all of DocBook's profiling attributes are no supported
- Various build fixes to make it work on Debian Wheezy, Fedora 20/21
  openSUSE 13.x, SLE 12, and Ubuntu 14.10
- tested DAPS on Debian Wheezy, Fedora 20/21 and Ubuntu 14.10
- Added script and stylesheets to migrate DocBook4 projects to
  DocBook 5 (libexec/daps-migrate)
- various fixes and improvements for bin/daps-init
- Added support for local static/ directories
- Established new locdrop workflow
- Fixed daps-init
- strings passed with --xsltparam no longer need to be uoted with double
  and single quotes--only use double quotes now
- Definied DAPS version for major, minor, and micro (configure.ac)
  - Introduced daps_version_{major,minor,micro} substitutions
  - Corrected URL from SourceForge to GitHub
  - Used DAPS version in AC_MSG_NOTICE
- Unified copyright statements
- Let configure change the Version in entity-decl.ent
- Created DOCTYPE and PI node manually for daps-xslt/profiling/
  stylesheets
- Added more testcases, fixed erfrors in test cases
- Significant documentation updates for version 2.0
- version string in manuals and man pages is now automatically set by
  configure/make
- provided useful READMEs in ASCII Doc format
- Support for both, /usr/bin/xml (SUSE) and /usr/bin/xmlstarlet (Ubuntu)

Bug fixes:
- issue #151: Detect DocBook XSL Stylesheet Version in daps
- issue #157: Add option for optimising PNG files for targets locdrop
  and
  package-src
- issue #223: Paths starting with ~ are now correctly resolved
- issue #227: Made --static for HTML builds the default
- issue #230: Moved DAPS config to ~/.config/daps/
- issue #249: Added support for all missing profiling attributes
  supported
  by DocBook
- issue #250: building Japanese text format requires external LANG
  setting
- issue #253: Implement Migration Stylesheets from DocBook 4 <-> DocBook
  5
- issue #260: Removed project-web directory (moved into gh-pages branch)
- check for embeeded fonts in PDF now works correctly
- ASPELL_LANG no longer gets overwritten with value from XML document if
  set in config or on the command line
- package-html no longer fails when called with --draft
- DocBook5 validation now works correctly
- epub is now correctly generated (STYLEIMG was not always set)
- existing man page builds were duplicated rather than overwritten

Project:
- project moved to GitHub
- Moved all stylesheet related files to github://openSUSE/suse-xsl
- obsolete docmanager code has been removed from the repository
- source clean-up
- source changes are tested with Travis

TODOs:
- test DocBook 5 with the latest DAPS develop version
- review DAPS documentation
- check existing test cases, add test cases for DocBook5
- add tests to Travis integration service
- Integrate manpage fixes from feature branch
- Integrate make improvements from feature branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants