Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming JeOS to Minimal-VM and moving to main download page #123

Merged
merged 21 commits into from
Nov 6, 2022

Conversation

vmoutoussamy
Copy link
Contributor

This is addressing #47 as well as renaming our openSUSE JeOS images to Minimal-VM. The rename is following up the SLES JeOS rename to Minimal-VM

_data/tumbleweed.yml Outdated Show resolved Hide resolved
@lkocman lkocman requested a review from hellcp September 29, 2022 13:58
@lkocman
Copy link
Contributor

lkocman commented Sep 29, 2022

Vincent, please try to run this locally (check bundler section in README), something like Tumbleweed container would work. for Leap container, you'd have to get newer bundler from ruby devel project. We need to co-ordinate on when to merge the change. As files are not renamed, we have to cross-check filenames etc. I don't see any rush as the rename still didn't happen. @hellcp do you have any ideas, how to rework the alternative downloads? Putting most used images (e.g. minimal RPi one) on main section could be seen positively by community.

@lkocman
Copy link
Contributor

lkocman commented Sep 29, 2022

@vmoutoussamy seems like your code can't be built. As you reference new section cloud and there is no corresponding icon to it.

kocman@localhost:~/Workspace/opensuse/get-o-o> bundle exec jekyll build
Configuration file: /home/lkocman/Workspace/opensuse/get-o-o/_config.yml
 Theme Config file: /home/lkocman/Workspace/opensuse/get-o-o/vendor/bundle/ruby/2.7.0/bundler/gems/jekyll-theme-22b75819c574/_config.yml
            Source: /home/lkocman/Workspace/opensuse/get-o-o
       Destination: /home/lkocman/Workspace/opensuse/get-o-o/_site
 Incremental build: disabled. Enable with --incremental
      Generating... 
                    done in 12.763 seconds.
 Auto-regeneration: disabled. Use --watch to enable.
lkocman@localhost:~/Workspace/opensuse/get-o-o> git checkout vincent && bundle exec jekyll build
Switched to branch 'vincent'
Configuration file: /home/lkocman/Workspace/opensuse/get-o-o/_config.yml
 Theme Config file: /home/lkocman/Workspace/opensuse/get-o-o/vendor/bundle/ruby/2.7.0/bundler/gems/jekyll-theme-22b75819c574/_config.yml
            Source: /home/lkocman/Workspace/opensuse/get-o-o
       Destination: /home/lkocman/Workspace/opensuse/get-o-o/_site
 Incremental build: disabled. Enable with --incremental
      Generating... 
  Liquid Exception: Could not locate the included file 'icons/cloud.svg' in any of ["/home/lkocman/Workspace/opensuse/get-o-o/_includes", "/home/lkocman/Workspace/opensuse/get-o-o/vendor/bundle/ruby/2.7.0/bundler/gems/jekyll-theme-22b75819c574/_includes"]. Ensure it exists in one of those directories and, if it is a symlink, does not point outside your site source. in /leap/15.4/index.html
                    ------------------------------------------------
      Jekyll 4.2.2   Please append `--trace` to the `build` command 
                     for any additional information or backtrace. 
                    ------------------------------------------------

@hellcp
Copy link
Member

hellcp commented Sep 29, 2022

Feel free to use the following:

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" width="24" height="24" fill="currentColor"><path d="M17 21H7A6 6 0 0 1 5.008 9.339a7 7 0 1 1 13.984 0A6 6 0 0 1 17 21zm0-12a5 5 0 1 0-9.994.243l.07 1.488-1.404.494A4.002 4.002 0 0 0 7 19h10a4 4 0 1 0-3.796-5.265l-1.898-.633A6.003 6.003 0 0 1 17 9z"/></svg>

taken from https://remixicon.com/

@hellcp
Copy link
Member

hellcp commented Sep 29, 2022

@hellcp do you have any ideas, how to rework the alternative downloads? Putting most used images (e.g. minimal RPi one) on main section could be seen positively by community.

My worry as always is how many of those images do we put there, and in what context they appear. If we have a person coming to install Tumbleweed on their laptop, we may not want to present them with server only images. Currently, we have it set up so that only the Installation images are displayed at all times (that's what https://github.com/openSUSE/get-o-o/blob/main/_data/tumbleweed.yml#L8 does), and depending on where they found the link to the Tumbleweed site, they may get ?type= query parameter in their URL (so if they clicked the Tumbleweed link from /desktop/, they will get ?type=desktop in their URL, which displays Live images apart from just Installation images, and the same is the case for /server/ and JeOS images right now).

So the question is, which images are common between all of the use cases we present to our users, those images should likely appear on the main page.

Currently translated at 95.8% (209 of 218 strings)

Translation: get-o-o/main
Translate-URL: https://l10n.opensuse.org/projects/get-o-o/main/it/
@vmoutoussamy
Copy link
Contributor Author

Guys, I'm completely lost here, I did build locally but I'm not seeing my changes at all. I'm missing something but I don't know what.
@hellcp I agree with you that the page might need a redesign but I won't be able to help here.
What I wanted to do here is to rename JeOS to Minimal-VM for TW and Leap and emphasis on our images like Leap Micro:
Screenshot 2022-10-17 at 16 19 29.

As of now we have 4 x86_64 Minimal-VM images and I would like to add aarch64 Minimal-VM as well. We have plan to support s390x with SLE15SP5 and even tho this image might not be high interested for openSUSE, we still would like to publish them as openSUSE Minimal-VM are the upstream of SLES Minimal-VM.

Last but not least there is much interests with our SLE Minimal-VM recently as it can be used with Rancher, cloud-native devs usually like to quickly fire-up a small VM. I believe the openSUSE community would have the same interest, so instead of grabbing the net-install Media, you can already used a Minimal-VM with or without cloud-init in the cloud but with jeos-firstboot for local install. Finally people using a non-openSUSE host might find handy to grab an openSUSE Minimal-VM for testing or production.

@hellcp
Copy link
Member

hellcp commented Oct 17, 2022

You may need to restart the jekyll server on changes in data files, because we aren't re-fetching data on changes

@vmoutoussamy
Copy link
Contributor Author

minileap154:~/Sandbox/get-o-o # git checkout
Your branch is up to date with 'origin/47-jeos-rename-to-minimal-was-live-images-and-jeos-are-too-hidden'.
minileap154:~/Sandbox/get-o-o # bundle install --path vendor/bundle
[DEPRECATED] The `--path` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set path 'vendor/bundle'`, and stop using this flag
Don't run Bundler as root. Bundler can ask for sudo if it is needed, and installing your bundle as root will break this application for all non-root users on this machine.
Using rake 13.0.6
Using public_suffix 4.0.6
Using addressable 2.8.0
Using bundler 2.1.4
Using colorator 1.1.0
Using concurrent-ruby 1.1.10
Using eventmachine 1.2.7
Using http_parser.rb 0.8.0
Using em-websocket 0.5.3
Using faraday-em_http 1.0.0
Using faraday-em_synchrony 1.0.0
Using faraday-excon 1.1.0
Using faraday-httpclient 1.0.1
Using multipart-post 2.1.1
Using faraday-multipart 1.0.3
Using faraday-net_http 1.0.1
Using faraday-net_http_persistent 1.2.0
Using faraday-patron 1.0.0
Using faraday-rack 1.0.0
Using faraday-retry 1.0.3
Using ruby2_keywords 0.0.5
Using faraday 1.10.0
Using faraday_middleware 1.2.0
Using ffi 1.15.5
Using forwardable-extended 2.6.0
Using human_size 1.1.2
Using i18n 1.10.0
Using sassc 2.4.0
Using jekyll-sass-converter 2.2.0
Using rb-fsevent 0.11.1
Using rb-inotify 0.10.1
Using listen 3.7.1
Using jekyll-watch 2.2.1
Using rexml 3.2.5
Using kramdown 2.3.2
Using kramdown-parser-gfm 1.1.0
Using liquid 4.0.3
Using mercenary 0.4.0
Using pathutil 0.16.2
Using rouge 3.28.0
Using safe_yaml 1.0.5
Using unicode-display_width 1.8.0
Using terminal-table 2.0.0
Using jekyll 4.2.2
Using jekyll-archives 2.2.1
Using jekyll-locale 0.5.1 from https://github.com/hellcp/jekyll-locale.git (at 1a9ba57@1a9ba57)
Using jekyll-paginate 1.1.0
Using jekyll-redirect-from 0.16.0
Using jekyll-theme-opensuse 0.7.1 from https://github.com/opensuse/jekyll-theme.git (at l10n-feat@22b7581)
Using webrick 1.7.0
Bundle complete! 9 Gemfile dependencies, 50 gems now installed.
Bundled gems are installed into `./vendor/bundle`
minileap154:~/Sandbox/get-o-o # bundle exec rake
minileap154:~/Sandbox/get-o-o # 
minileap154:~/Sandbox/get-o-o # bundle exec jekyll build
Configuration file: /root/Sandbox/get-o-o/_config.yml
 Theme Config file: /root/Sandbox/get-o-o/vendor/bundle/ruby/2.5.0/bundler/gems/jekyll-theme-22b75819c574/_config.yml
            Source: /root/Sandbox/get-o-o
       Destination: /root/Sandbox/get-o-o/_site
 Incremental build: disabled. Enable with --incremental
      Generating... 
                    done in 16.31 seconds.
 Auto-regeneration: disabled. Use --watch to enable.
minileap154:~/Sandbox/get-o-o # grep -R Minimal-VM *
minileap154:~/Sandbox/get-o-o # 

So I don't see my changes as grep is returning nothing...
Could you please help here?

@Vogtinator
Copy link
Member

It looks like you checked out the target branch, not the source branch of this pull request. Your changes are in your main branch.

@Vogtinator
Copy link
Member

I tried to build it locally here and it still fails due to the missing cloud.svg image.

@hellcp
Copy link
Member

hellcp commented Oct 20, 2022

For the missing image refer to #123 (comment)

@vmoutoussamy
Copy link
Contributor Author

Ok so I should have the renamed fixed now without changing the layout. What do you think?

I will create a dedicated PR for putting Minimal-VM into the main download page.

However I need some help to understand how to use minimal-vm_images and minimal-vm_info instead of jeos_images and jeos_info. Because if I set them then the page will not show the following:
Screenshot 2022-10-21 at 15 51 11
Screenshot 2022-10-21 at 15 51 05

@hellcp
Copy link
Member

hellcp commented Oct 21, 2022

I'm gonna bet it's because yaml doesn't accept - as a valid element of a key and so keys with -s in them are not rendered at all

_data/locales/en.yml Outdated Show resolved Hide resolved
_data/locales/en.yml Outdated Show resolved Hide resolved
@hellcp
Copy link
Member

hellcp commented Oct 21, 2022

I will create a dedicated PR for putting Minimal-VM into the main download page.

We have that already, just open the site with https://get.opensuse.org/leap/15.4?type=server#download, and JeOS will be displayed as an option below the Installation images

@vmoutoussamy
Copy link
Contributor Author

I will create a dedicated PR for putting Minimal-VM into the main download page.

We have that already, just open the site with https://get.opensuse.org/leap/15.4?type=server#download, and JeOS will be displayed as an option below the Installation images

oh this is really nice but is this known to anyone at all? I really need helps to rename JeOS by Minimal-VM as you can see in the screenshot below:
Screenshot 2022-10-26 at 11 59 14

It feel like the main page https://get.opensuse.org/leap/15.4 should maybe look like https://getfedora.org,

@vmoutoussamy vmoutoussamy requested review from lkocman and hellcp and removed request for lkocman October 26, 2022 14:00
@hellcp
Copy link
Member

hellcp commented Oct 26, 2022

You will still need to replace - with _ in yaml and references, so that Minimal VM name is actually displayed on the website

@vmoutoussamy
Copy link
Contributor Author

I just fixed the info issue and made sure that TW is similar:
Screenshot 2022-10-27 at 17 53 50
Screenshot 2022-10-27 at 17 53 33
Screenshot 2022-10-27 at 17 53 22

@hellcp
Copy link
Member

hellcp commented Oct 27, 2022

Is the note about arm images on the wiki still needed? Also do we need to say Minimal for everything? The title already says Minimal Virtual Machine, so saying Minimal XEN feels pointless

@vmoutoussamy
Copy link
Contributor Author

Is the note about arm images on the wiki still needed?

Yes for the arm image wiki link, we (Minimal-VM team) have an history with the team building the JeOS arm image. Even tho we do not share the same name anymore some people and partners will still be interested by finding them.

Also do we need to say Minimal for everything? The title already says Minimal Virtual Machine, so saying Minimal XEN feels pointless

Agreed 100%

_data/locales/en.yml Outdated Show resolved Hide resolved
_data/locales/en.yml Outdated Show resolved Hide resolved
_data/locales/en.yml Outdated Show resolved Hide resolved
_data/locales/en.yml Outdated Show resolved Hide resolved
_data/locales/en.yml Outdated Show resolved Hide resolved
@hellcp hellcp merged commit c09c9e2 into openSUSE:47-jeos-rename-to-minimal-was-live-images-and-jeos-are-too-hidden Nov 6, 2022
@vmoutoussamy
Copy link
Contributor Author

@hellcp We need to revert the change for now!
Unfortunately the rename of the image is not done yet! It is expected to be done with the upcoming Leap 15.4 refresh.
@lkocman could you give an ETA for the quarterly update 1 for 15.4?

@Vogtinator
Copy link
Member

Unfortunately the rename of the image is not done yet! It is expected to be done with the upcoming Leap 15.4 refresh.
@lkocman could you give an ETA for the quarterly update 1 for 15.4?

I'll request again that we ignore 15.4 here and just do the rename for 15.5+.

@lkocman
Copy link
Contributor

lkocman commented Nov 10, 2022

Let's do it for 15.4, we've already done plenty changes for CR DVDs. We need to act quickly, since the web is now practically broken. Thanks for your understading @Vogtinator

@Vogtinator
Copy link
Member

If we need to act quickly, it's several orders of magnitude more easy to fix get.o.o than to perform the multi-step process required to do the rename properly. That will take until next week at least.

@lkocman
Copy link
Contributor

lkocman commented Nov 10, 2022

I can live with that ETA Fabian, revert would not move us anywhere forward and this has been a painful topic.

@Vogtinator
Copy link
Member

revert would not move us anywhere forward

We'd get working download links again. It's been working absolutely fine until now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants