New arabic language package #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added Arabic langpack
Add entry for Arabic language in the languages dropdown menu
Some fixes on the translation
|
@msaied93 thank you for the contribution. Can you try to look into how to change the direction to RTL ? |
Add an event handler to switch page direction when choosing ar lang.
|
Well, I guess that does the trick. |
| @@ -252,6 +253,19 @@ $(document).on("ready", function(){ | |||
| } | |||
|
|
|||
| }); | |||
|
|
|||
| //change page direction when changing lang into/from ar | |||
| $(window.lang).on("afterUpdate", function (event, currentLang, newLang, pack1, pack2) { | |||
There was a problem hiding this comment.
why are you passing the arguments event, pack1 and pack2 ? I dont see where you are using them below
|
There seem to be other conflicts with the animation and general layout. This PR will require much more work than just changing the css to direction: rtl. IMO. |
|
Can you move the actual translations to subversions? |
|
I've opened #81 to implement the missing features, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I added Arabic translation; however, there is still more work to be done: the page direction should become RTL when choosing Arabic language... not sure how to do it.