Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if exported log is same as existing log #15

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Check if exported log is same as existing log #15

merged 2 commits into from
Aug 28, 2023

Conversation

mimi1vx
Copy link
Member

@mimi1vx mimi1vx commented Aug 18, 2023

If log and exported date are same skip exporting.

Copy link
Contributor

@perlpunk perlpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be tested?

@mimi1vx
Copy link
Member Author

mimi1vx commented Aug 18, 2023

Manually yeah, simple unit test also ...

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 87.50% and project coverage change: +1.74% 🎉

Comparison is base (69d4632) 11.72% compared to head (af20fec) 13.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   11.72%   13.47%   +1.74%     
==========================================
  Files          98       98              
  Lines        5653     5656       +3     
==========================================
+ Hits          663      762      +99     
+ Misses       4990     4894      -96     
Files Changed Coverage Δ
mtui/export/base.py 35.92% <87.50%> (+35.92%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mimi1vx mimi1vx requested a review from perlpunk August 27, 2023 17:41
@mimi1vx mimi1vx merged commit 16f6bed into main Aug 28, 2023
2 checks passed
@okurz okurz deleted the osukup/dedup branch August 30, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants