Reconverge with OBS [part 3] #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is failing on Travis since the environment is missing both needs to be protected with: although this fake section header thing makes me uncomfortable. The |
|
@M0ses The question is, why was this not failing before. I presume that there is some new test in this PR which is now covering this code path but I haven't checked. If so, the fix commit needs to be inserted in the sequence of commits prior to the new test, to avoid breaking |
Since the tests now exercise the get_config_options() code path, we need to ensure we don't die if [tar_scm] config section is missing (e.g. if we're testing on a machine which has neither /etc/obs/services/tar_scm nor ~/.obs2/tar_scm.
aspiers
force-pushed
the
reconverge
branch
2 times, most recently
from
587ff60
to
b3e197a
Compare
aspiers
force-pushed
the
reconverge
branch
2 times, most recently
from
3d8f40a
to
72f9122
Compare
Closed
aspiers
force-pushed
the
reconverge
branch
6 times, most recently
from
2fe15bd
to
d05fb14
Compare
This is the conventional Python approach, and it's more flexible than editing a Makefile rule.
Piping test output through tee means that we have to now be careful to catch failures in pipelines, otherwise make(1) would silently ignore a failure of the test suite run caused by a module not being installed.
* Make it easier for cleanup script to identify oldest repos
aspiers
force-pushed
the
reconverge
branch
2 times, most recently
from
20c00a1
to
68eccf4
Compare
This reverts commit c9a319a ("temporarily disable PEP8 test whilst we reconverge with OBS").
This was referenced Apr 13, 2017
Closed
This was referenced Apr 13, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third in a series of PRs to reconverge the codebase with the currently live code in OBS, which is represented by the changes in #123. (#125 was the first part, and #128 was the second.)
It still needs a commit to fix the PEP8 issues.