Ported the application to Qt5 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QString::toAscii() has been deprecated since Qt5 which causes build failure. Using QString::toLatin1() instead.
| @@ -28,7 +28,7 @@ FirstScreen::FirstScreen( PackageBackend *backend, QString *tmpFileName, const Q | |||
| QVBoxLayout *mainLayout = new QVBoxLayout; | |||
| mainLayout->setSpacing( 0 ); | |||
|
|
|||
| QFile dataFile( m_tmpFileName->toAscii() ); | |||
| QFile dataFile( m_tmpFileName->toLatin1() ); | |||
There was a problem hiding this comment.
Curious to know why converting to Latin1 not UTF?
There was a problem hiding this comment.
Cause Latin1 and Ascii encodings have a bit more in common than with UTF. Changing it to UTF ( toUtf8() ) is not a problem though.
There was a problem hiding this comment.
Note that we don't know what's the encoding used by the system of every user, so the right way to do it would be to use QString::toLocal8Bit, since that will use whatever the system is configured with, be it utf8 (usually), latin1 or whatever. Can you change that?
There was a problem hiding this comment.
Yes, sure. I'm on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FirstScreen.cpp (Line 31) - QString::toAscii() is not longer supported. Therefore, using QString::toLatin1() instead.