[webui] proper error handling for changing review state

openSUSE · Jun 23, 2014 · 3ff827c · 3ff827c
1 parent 5385caa
commit 3ff827c
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/api/app/controllers/webui/request_controller.rb b/src/api/app/controllers/webui/request_controller.rb
@@ -69,8 +69,14 @@ def modify_review
     elsif state.nil?
       flash[:error] = "Unknown state to set"
     else
-      req.permission_check_change_review!(opts)
-      req.change_review_state(state, opts)
+      begin
+        req.permission_check_change_review!(opts)
+        req.change_review_state(state, opts)
+      rescue BsRequestPermissionCheck::ReviewChangeStateNoPermission
+        flash[:error] = "Not permitted to change review state: #{e.message}"
+      rescue APIException => e
+        flash[:error] = "Unable changing review state: #{e.message}"
+      end
     end
 
     redirect_to :action => 'show', :id => req.id