Implement filters for Workflow Runs #12123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danidoni
force-pushed
the
implement-filters-for-a-workflow-run-index-page
branch
8 times, most recently
from
0201ce8
to
5172d18
Compare
krauselukas
reviewed
Jan 24, 2022
danidoni
force-pushed
the
implement-filters-for-a-workflow-run-index-page
branch
7 times, most recently
from
4d76009
to
7160191
Compare
dmarcoux
reviewed
Jan 24, 2022
krauselukas
force-pushed
the
implement-filters-for-a-workflow-run-index-page
branch
2 times, most recently
from
a0dc4ed
to
935fa28
Compare
hennevogel
reviewed
Feb 2, 2022
krauselukas
force-pushed
the
implement-filters-for-a-workflow-run-index-page
branch
5 times, most recently
from
f69a987
to
423286f
Compare
|
LGTM! |
krauselukas
force-pushed
the
implement-filters-for-a-workflow-run-index-page
branch
from
423286f
to
8b4a640
Compare
hennevogel
previously requested changes
Feb 3, 2022
krauselukas
force-pushed
the
implement-filters-for-a-workflow-run-index-page
branch
from
8b4a640
to
3378bde
Compare
|
I suggest a correction for the commit description "Move hook_event logic from workflow_run_row view component to model" |
krauselukas
force-pushed
the
implement-filters-for-a-workflow-run-index-page
branch
2 times, most recently
from
1f44804
to
b865037
Compare
This logic can also be used in the workflow runs finder class and better fits in the model itself than the view component. Co-authored-by: Daniel Donisa <daniel.donisa@suse.com>
This PR implements several filters to help you narrow down your search for a specific workflow run. It filters by workflow run status (success, running, failure) and by source event (pull request, push, both GitHub and GitLab). Co-authored-by: Daniel Donisa <daniel.donisa@suse.com>
krauselukas
force-pushed
the
implement-filters-for-a-workflow-run-index-page
branch
from
b865037
to
9d11375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements several filters to help you narrow down your search
for a specific workflow run.
It filters by workflow run status (success, running, failure) and by
source event (pull request, push, both GitHub and GitLab).
TODO