Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow commenting on submit request diff lines #13912

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Allow commenting on submit request diff lines #13912

merged 2 commits into from
Mar 6, 2023

Conversation

hellcp-work
Copy link
Contributor

Depends on #13910

Allows users to comment on submit request action diffs.

Screenshot from 2023-02-28 13-06-33

How to test

  1. Create a submit request with a diff
  2. Open changes tab
  3. Hover over a line
  4. Click a button that shows up
  5. Write a comment and save it

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Feb 28, 2023
@hellcp-work hellcp-work marked this pull request as draft February 28, 2023 12:08
@hellcp-work hellcp-work added the review-app Apply this label if you want a review app started label Feb 28, 2023
@hellcp-work
Copy link
Contributor Author

Allow creation of comments on changed/removed lines of a request diff (L)

@obs-bot
Copy link
Collaborator

obs-bot commented Feb 28, 2023

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-sr_action_comments

@hellcp-work hellcp-work force-pushed the sr_action_comments branch 4 times, most recently from 80fdb95 to c01ba65 Compare February 28, 2023 16:46
@codecov
Copy link

codecov bot commented Feb 28, 2023 •
edited
Loading

Codecov Report

Merging #13912 (59f100a) into master (c57a10b) will decrease coverage by 0.04%.
The diff coverage is 62.06%.

❗ Current head 59f100a differs from pull request most recent head 7524a72. Consider uploading reports for the commit 7524a72 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13912      +/-   ##
==========================================
- Coverage   88.20%   88.17%   -0.04%     
==========================================
  Files         733      733              
  Lines       24517    24530      +13     
==========================================
+ Hits        21625    21629       +4     
- Misses       2892     2901       +9

@hellcp-work hellcp-work force-pushed the sr_action_comments branch 3 times, most recently from 3417766 to 6fa2736 Compare March 2, 2023 08:46
@rubhanazeem
Copy link
Member

The comment section stays open when you add a new comment. Is it possible to remove that additional comment section?

@hellcp-work
Copy link
Contributor Author

The comment section stays open when you add a new comment. Is it possible to remove that additional comment section?

This is what is meant here:
Screenshot from 2023-03-02 11-52-58
I will address this in another PR

@hellcp-work hellcp-work marked this pull request as ready for review March 3, 2023 12:09
@hellcp-work hellcp-work mentioned this pull request Mar 3, 2023
Merged
@rubhanazeem rubhanazeem merged commit b2a8d00 into openSUSE:master Mar 6, 2023
@DimStar77
Copy link
Contributor

Tried this new feature:

https://build.opensuse.org/request/show/1069679

I doubt that people will 'find' the comments and act on them

@rubhanazeem rubhanazeem mentioned this pull request Mar 6, 2023
Closed
@hennevogel
Copy link
Member

@DimStar77 integrating this into conversation etc. is in the backlog https://trello.com/c/X62LRP8N

@krauselukas krauselukas mentioned this pull request Mar 8, 2023
Merged
krauselukas added a commit to krauselukas/open-build-service that referenced this pull request Mar 9, 2023
@krauselukas
Gather metrics about comment creation on request action diffs
cc91554 
Instrumenting the feature introduced in openSUSE#13912
@krauselukas krauselukas mentioned this pull request Mar 9, 2023
Merged
krauselukas added a commit to krauselukas/open-build-service that referenced this pull request Mar 10, 2023
@krauselukas
Gather metrics about comment creation on request action diffs
e938259 
Instrumenting the feature introduced in openSUSE#13912
krauselukas added a commit to krauselukas/open-build-service that referenced this pull request Mar 10, 2023
@krauselukas
Gather metrics about comment creation on request action diffs
ff4dfdf 
Instrumenting the feature introduced in openSUSE#13912
danidoni pushed a commit to krauselukas/open-build-service that referenced this pull request Mar 13, 2023
@krauselukas @danidoni
Gather metrics about comment creation on request action diffs
5f0889a 
Instrumenting the feature introduced in openSUSE#13912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danidoni danidoni danidoni approved these changes

@rubhanazeem rubhanazeem rubhanazeem approved these changes

Assignees
No one assigned
Labels
Frontend Things related to the OBS RoR app review-app Apply this label if you want a review app started
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hellcp-work @obs-bot @rubhanazeem @DimStar77 @hennevogel @danidoni