Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: computing timeline icon and avatar alignment #13945

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

ncounter
Copy link
Contributor

@ncounter ncounter commented Mar 3, 2023

Since #13876 the timeline icon alignment was partially broken. It is fixed now giving the timeline-item-avatar a fixed size and aligning the rest accordingly.

Before

timeline-alignment-before

After

timeline-alignment-after

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Mar 3, 2023
@ncounter ncounter added the review-app Apply this label if you want a review app started label Mar 3, 2023
@obs-bot
Copy link
Collaborator

obs-bot commented Mar 3, 2023

Review app will appear here: http://obs-reviewlab.opensuse.org/ncounter-timeline-alignment

@ncounter ncounter merged commit e57d07e into openSUSE:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app review-app Apply this label if you want a review app started
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants