Core component: modal #15032
Merged
Core component: modal #15032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncounter
force-pushed
the
modal-core-component
branch
from
fe5afd8
to
fbf28ce
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #15032 +/- ##
=======================================
Coverage 86.88% 86.89%
=======================================
Files 777 778 +1
Lines 25708 25718 +10
=======================================
+ Hits 22337 22347 +10
Misses 3371 3371 |
ncounter
force-pushed
the
modal-core-component
branch
3 times, most recently
from
71686a8
to
e5780ee
Compare
hellcp-work
requested changes
Oct 12, 2023
ncounter
force-pushed
the
modal-core-component
branch
5 times, most recently
from
d12ede6
to
d3eafcf
Compare
hellcp-work
reviewed
Oct 12, 2023
ncounter
force-pushed
the
modal-core-component
branch
from
d3eafcf
to
d6db763
Compare
ncounter
force-pushed
the
modal-core-component
branch
from
d6db763
to
fb1c2e8
Compare
|
Review app will appear here: http://obs-reviewlab.opensuse.org/ncounter-modal-core-component |
hellcp-work
approved these changes
Oct 16, 2023
ncounter
force-pushed
the
modal-core-component
branch
from
fb1c2e8
to
be22edb
Compare
ncounter
force-pushed
the
modal-core-component
branch
from
be22edb
to
ed45500
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce modal core component in order to standardize and reuse it.
Previews available at http://obs-reviewlab.opensuse.org/ncounter-modal-core-components/rails/view_components/modal_component
Same as #15030