Catch generic server exceptions when connecting to GitHub #16834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoj
force-pushed
the
fix/issue_16691
branch
3 times, most recently
from
a99bba2
to
5907616
Compare
hennevogel
requested changes
Sep 11, 2024
Exceptions with code 504 were not catched. Rescuing from generic exceptions in the range of 500..599 with the Octokit::ServerError prevents from crashing without notifying back OBS.
eduardoj
force-pushed
the
fix/issue_16691
branch
from
5907616
to
1296e14
Compare
hennevogel
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions with code 504 were not catched.
Rescuing from generic exceptions in the range of 500..599 with Octokit::ServerError prevents from crashing without notifying back OBS.
See #16691. Related to #12661.
To see exceptions supported by Octokit: https://github.com/octokit/octokit.rb/blob/71e3d209400ff29440d87581db90314b6272355b/lib/octokit/error.rb#L19-L37
Octokit::ServerError exceptions: https://github.com/octokit/octokit.rb/blob/71e3d209400ff29440d87581db90314b6272355b/lib/octokit/error.rb#L343-L356