Feature/multibuild release #4033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisBr
force-pushed
the
feature/multibuild_release
branch
2 times, most recently
from
8576030
to
cc66be4
Compare
Codecov Report
@@ Coverage Diff @@
## master #4033 +/- ##
==========================================
+ Coverage 89.17% 89.18% +<.01%
==========================================
Files 309 309
Lines 18221 18236 +15
==========================================
+ Hits 16249 16264 +15
Misses 1972 1972
|
hennevogel
added
the
DO NOT MERGE ⚠️
Introduced in f08032e. Quick and dirty c&p from the old test suite to get the PR merged as it is required by release team.
Introduced in f08032e. Package.get_by_name_and_project raised an UnknownObject exception for multibuild containers as the follow_multibuild option was missing. Just using now the pkg object.
To DRY it up and make it more readable.
ChrisBr
force-pushed
the
feature/multibuild_release
branch
from
cc66be4
to
6c29a4f
Compare
ChrisBr
added
Feature
Monkey Patched 🙈
mdeniz
approved these changes
Oct 18, 2017
evanrolfe
approved these changes
Oct 18, 2017
There was a problem hiding this comment.
LGTM as a quick and necessary fix for a problem we're currently experiencing.
However I have to say some of the code here is a bit of an eye sore - too much logic in controllers, use of helpers methods to organise business logic, variable names like pkg, parsing of the params with regex in controllers etc.
|
@evanrolfe Yep! The whole source_controller with more than 1500 + the source_controller_test with more than 2k LOC is a mess 😢 😢 |
|
deploy, deploy!! :) |
|
@coolo already monkeypatched since last week :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked the commit from #3672 as @adrianschroeter is currently busy with other stuff.
This is currently blocking us from deployment. As this is already monkey patched on build.o.o and I don't want to deploy and applying this huge patch again.
@mdeniz @evanrolfe please have a look.