Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add openh264 #119

Merged
merged 12 commits into from
Feb 13, 2023
Merged

add openh264 #119

merged 12 commits into from
Feb 13, 2023

Conversation

13werwolf13
Copy link
Contributor

@13werwolf13
Copy link
Contributor Author

it was only after I made the changes that I noticed that /usr/share/licenses/gstreamer-1.20-plugin-openh264 conflicts between the gstreamer-plugins-bad-codecs and gstreamer-1.20-plugin-openh264 packages. so I created a pr in draft. I think I need to contact the maintainer of the gstreamer-plugins-bad-codecs package in the packman repo to rule out this conflict. but I don't know how to do it.

@13werwolf13
Copy link
Contributor Author

13werwolf13 commented Feb 6, 2023

I write email to packman@links2linux.de and am awaiting a response. I will be glad if someone more knowledgeable can help.

@DarkWav
Copy link

DarkWav commented Feb 8, 2023

it was only after I made the changes that I noticed that /usr/share/licenses/gstreamer-1.20-plugin-openh264 conflicts between the gstreamer-plugins-bad-codecs and gstreamer-1.20-plugin-openh264 packages. so I created a pr in draft. I think I need to contact the maintainer of the gstreamer-plugins-bad-codecs package in the packman repo to rule out this conflict. but I don't know how to do it.

This file conflict should be resolved with this request: https://pmbs.links2linux.org/request/show/5684
(gstreamer-plugins-bad-codecs >= 1.22.0-2.1)
Can you try again and check if installing gstreamer-plugins-bad-codecs and gstreamer-1.20-plugin-openh264 simultaneously works now?

@13werwolf13
Copy link
Contributor Author

it was only after I made the changes that I noticed that /usr/share/licenses/gstreamer-1.20-plugin-openh264 conflicts between the gstreamer-plugins-bad-codecs and gstreamer-1.20-plugin-openh264 packages. so I created a pr in draft. I think I need to contact the maintainer of the gstreamer-plugins-bad-codecs package in the packman repo to rule out this conflict. but I don't know how to do it.

This file conflict should be resolved with this request: https://pmbs.links2linux.org/request/show/5684 (gstreamer-plugins-bad-codecs >= 1.22.0-2.1) Can you try again and check if installing gstreamer-plugins-bad-codecs and gstreamer-1.20-plugin-openh264 simultaneously works now?

so, for tumbleweed this work
but not for leap

@13werwolf13
Copy link
Contributor Author

13werwolf13 commented Feb 8, 2023

and for leap need be removed $releasever from repo uri

@DarkWav
Copy link

DarkWav commented Feb 8, 2023

it was only after I made the changes that I noticed that /usr/share/licenses/gstreamer-1.20-plugin-openh264 conflicts between the gstreamer-plugins-bad-codecs and gstreamer-1.20-plugin-openh264 packages. so I created a pr in draft. I think I need to contact the maintainer of the gstreamer-plugins-bad-codecs package in the packman repo to rule out this conflict. but I don't know how to do it.

This file conflict should be resolved with this request: https://pmbs.links2linux.org/request/show/5684 (gstreamer-plugins-bad-codecs >= 1.22.0-2.1) Can you try again and check if installing gstreamer-plugins-bad-codecs and gstreamer-1.20-plugin-openh264 simultaneously works now?

so, for tumbleweed this work but not for leap

I made a request to fix it for Leap 15.4, too: https://pmbs.links2linux.org/request/show/5685
Leap 15.3 is EOL so it shouldn't matter there.

@13werwolf13
Copy link
Contributor Author

so, i do some changes. now that's code work on tumbleweed and leaap to.
thanx @NikitaBeloglazov for the python advice
pr can be approwed after that

@13werwolf13 13werwolf13 marked this pull request as ready for review February 8, 2023 18:57
@DarkWav
Copy link

DarkWav commented Feb 8, 2023

pr can be approwed after that

Packman SR was accepted, so we are good to go, right?

@13werwolf13
Copy link
Contributor Author

pr can be approwed after that

Packman SR was accepted, so we are good to go, right?

in the morning I double-checked everything on clean, freshly created lxc containers. I confirm that both leap and tumbleweed work correctly.

@13werwolf13
Copy link
Contributor Author

as I understand it, it's time to invite @asdil12 to this thread

@lkocman
Copy link

lkocman commented Feb 9, 2023

Just please keep in mind that we use version-less Leap repository. I'm not sure to what %project espands in the changes. So I'm rather raising the fact.

@lkocman
Copy link

lkocman commented Feb 9, 2023

One thing to keep in mind is that users, who will do a new install of Leap 15.5 or TW will have repository enabled by default.

opi/__init__.py Outdated Show resolved Hide resolved
opi/__init__.py Outdated Show resolved Hide resolved
opi/__init__.py Outdated Show resolved Hide resolved
opi/__init__.py Outdated Show resolved Hide resolved
opi/plugins/packman.py Outdated Show resolved Hide resolved
opi/plugins/packman.py Outdated Show resolved Hide resolved
13werwolf13 and others added 7 commits February 9, 2023 21:33
Co-authored-by: Dominik Heidler <dominik@heidler.eu>
Co-authored-by: Dominik Heidler <dominik@heidler.eu>
Co-authored-by: Dominik Heidler <dominik@heidler.eu>
Co-authored-by: Dominik Heidler <dominik@heidler.eu>
Co-authored-by: Dominik Heidler <dominik@heidler.eu>
Co-authored-by: Dominik Heidler <dominik@heidler.eu>
opi/__init__.py Outdated Show resolved Hide resolved
@asdil12
Copy link
Member

asdil12 commented Feb 10, 2023

@13werwolf13
I pushed some changes to this PR on my own to detect if the openh264 repo is already present as @lkocman mentioned.
Could you have another check if it works? Please also test if it works when the openh264 repo is already added but has a name (repo name in the .repo file contents and filename of the .repo file) other than openh264.

@13werwolf13
Copy link
Contributor Author

@asdil12 I downloaded the repo file directly from the repository, it has a different name. the definition seemed to work correctly, but I see it. So far I don't understand what went wrong.

image

the behavior is the same for both leap and tumbleweed

@asdil12
Copy link
Member

asdil12 commented Feb 13, 2023

Could you show me an ls of your /etc/zypp/repos.d directory and the contents of the openh264 repo file?

Instalation fails otherwise, as zypper only accepts alias, not repo file
name as argument.
@asdil12
Copy link
Member

asdil12 commented Feb 13, 2023

In the meantime I think I found the issue and pushed some fixes. Could you try again with the latest version?

@13werwolf13
Copy link
Contributor Author

In the meantime I think I found the issue and pushed some fixes. Could you try again with the latest version?

image

now it works as it should!

thanks for your work!

@asdil12 asdil12 merged commit ca06e1e into openSUSE:master Feb 13, 2023
@13werwolf13
Copy link
Contributor Author

@asdil12 a question from the community: in what release will these changes be (how soon to expect in the distribution's repositories)?

@asdil12
Copy link
Member

asdil12 commented Feb 13, 2023

The changes are included in opi 2.13.0.
For tumbleweed it depends when the submit request (https://build.opensuse.org/request/show/1065419) is accepted.
It should be merged in the next two days or so.
Then it is in Factory and the next (successfully tested) snapshot of Factory will be released as tumbleweed. That usually happens every two to three days.
So I would expect it to hit tumbleweed next week.

If you want to try it out earlier, you can install the newest version of opi from the utilities devel repo using opi ;).

@asdil12
Copy link
Member

asdil12 commented Feb 13, 2023

Another SR as it turns out that libcurl doesn't like a redirect from the https repo to the http cisco CDN:
https://build.opensuse.org/request/show/1065545

The url for the gpgkey stays https.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants