Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install ms edge versions using single plugin #80

Merged
merged 3 commits into from
Nov 15, 2021
Merged

Install ms edge versions using single plugin #80

merged 3 commits into from
Nov 15, 2021

Conversation

asdil12
Copy link
Member

@asdil12 asdil12 commented Oct 29, 2021 •
edited
Loading

Fixes #78

@asdil12
Copy link
Member Author

asdil12 commented Oct 29, 2021

Testsuite passed locally.

giovcandido
giovcandido suggested changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@giovcandido giovcandido left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add microsoft-edge-stable to the options list. It's now a thing!

@giovcandido
Copy link
Contributor

By the way, good work!

@giovcandido
Copy link
Contributor

Testsuite passed locally.

I think you need to update the tests, so they work when you need to choose the package channel (stable, beta, dev).

@trmdi
Copy link

trmdi commented Nov 2, 2021 •
edited
Loading

Maybe an idea:

Currently there is 2 separated rows for msedge, it can be improved like this:
instead of:

msedge-beta Microsoft Edge Beta
msedge-dev Microsoft Edge Dev

we show:

msedge-{branch} Microsoft Edge (branch: beta, dev, stable)

And opi msedge will be redirected to the stable branch.

@trmdi trmdi mentioned this pull request Nov 2, 2021
Closed
@asdil12 asdil12 merged commit a05d2b5 into openSUSE:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovcandido giovcandido giovcandido requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

give the choice of package channel (stable / beta / dev/ insider) to be installed
3 participants
@asdil12 @giovcandido @trmdi