Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add req_states parameter to osc.core.get_review_list #1323

Merged
merged 1 commit into from
May 19, 2023

Conversation

Vogtinator
Copy link
Member

@Vogtinator Vogtinator commented May 12, 2023

Keep the original behaviour by default, but allow other callers to also request reviews on e.g. declined SRs.

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.01 ⚠️

Comparison is base (1ad022a) 28.91% compared to head (7013509) 28.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1323      +/-   ##
==========================================
- Coverage   28.91%   28.90%   -0.01%     
==========================================
  Files          36       36              
  Lines       16700    16702       +2     
==========================================
  Hits         4828     4828              
- Misses      11872    11874       +2     
Impacted Files Coverage Δ
osc/core.py 35.62% <0.00%> (-0.02%) ⬇️
osc/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Keep the original behaviour by default, but allow other callers to also
request reviews on e.g. declined SRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants