Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Request and PackageSources XML models #1502

Merged
merged 9 commits into from
Mar 4, 2024

Conversation

dmach
Copy link
Contributor

@dmach dmach commented Mar 1, 2024

No description provided.

@pep8speaks
Copy link

pep8speaks commented Mar 1, 2024

Hello @dmach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 121:9: E128 continuation line under-indented for visual indent
Line 122:9: E128 continuation line under-indented for visual indent
Line 123:9: E128 continuation line under-indented for visual indent
Line 124:9: E128 continuation line under-indented for visual indent
Line 125:9: E128 continuation line under-indented for visual indent
Line 126:9: E128 continuation line under-indented for visual indent
Line 127:5: E124 closing bracket does not match visual indentation

Line 114:121: E501 line too long (144 > 120 characters)
Line 136:121: E501 line too long (137 > 120 characters)
Line 164:121: E501 line too long (138 > 120 characters)
Line 194:121: E501 line too long (136 > 120 characters)

Line 287:121: E501 line too long (125 > 120 characters)

Comment last updated at 2024-03-04 14:00:40 UTC

osc/obs_api/package_sources_file.py Fixed Show fixed Hide fixed
osc/core.py Fixed Show fixed Hide fixed
osc/util/models.py Fixed Show fixed Hide fixed
osc/obs_api/request_action.py Dismissed Show dismissed Hide dismissed
osc/obs_api/request_action.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 8.93246% with 418 lines in your changes are missing coverage. Please review.

Project coverage is 31.08%. Comparing base (78b07e6) to head (d768eff).
Report is 19 commits behind head on master.

Files Patch % Lines
osc/obs_api/request_action.py 0.00% 130 Missing ⚠️
osc/obs_api/request.py 0.00% 44 Missing ⚠️
osc/obs_api/request_review.py 0.00% 25 Missing ⚠️
osc/obs_api/package_sources.py 0.00% 22 Missing ⚠️
osc/obs_api/request_action_options.py 0.00% 16 Missing ⚠️
osc/obs_api/enums.py 0.00% 13 Missing ⚠️
osc/obs_api/linkinfo.py 0.00% 12 Missing ⚠️
osc/obs_api/request_sourcediff.py 0.00% 12 Missing ⚠️
osc/obs_api/request_state.py 0.00% 11 Missing ⚠️
osc/obs_api/package_sources_file.py 0.00% 10 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
- Coverage   31.41%   31.08%   -0.33%     
==========================================
  Files          71       95      +24     
  Lines       18486    18826     +340     
==========================================
+ Hits         5807     5852      +45     
- Misses      12679    12974     +295     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmach dmach force-pushed the xmlmodel-request branch 2 times, most recently from 620f8bc to 1431b44 Compare March 4, 2024 12:53
tests/test_models.py Fixed Show fixed Hide fixed
tests/test_models.py Fixed Show fixed Hide fixed
tests/test_models.py Fixed Show fixed Hide fixed
tests/test_models.py Fixed Show fixed Hide fixed
tests/test_models.py Fixed Show fixed Hide fixed
tests/test_models.py Fixed Show fixed Hide fixed
tests/test_models.py Fixed Show fixed Hide fixed
tests/test_models.py Fixed Show fixed Hide fixed
tests/test_models.py Fixed Show fixed Hide fixed
tests/test_models.py Fixed Show fixed Hide fixed
@dmach dmach merged commit 2129908 into openSUSE:master Mar 4, 2024
31 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants