Invitation for booth responsibles #2535

rahul2240 · 2019-06-09T15:39:58Z

Related to #2527

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the upstream master branch.
The tests pass locally with my changes.
I have added tests that prove my fix is effective or that my feature works(if appropriate).

Need

Whenever a conference is organized, people submit booth request for that conference. It is possible to add responsibles to booth but only registered users can be added as responsibles.

With this PR, booth submitter will be able to invite unregistered users to join the app and handle the booth. Making it easier for the submitter to add users as responsibles only one time rather than waiting for users to first join and then adding them as responsibles.

Workflow

User submits a booth request.
This invitation field will be available in new booth and edit booth form for submitters.
User can enter any number of emails that are needed to be invited.
If user with that email already exists in user db then he/she will become booth responsible.
If user with that email doesn't exist in user db then that user will be created and an invitation mail will be sent to the user with an invitation token to join the app.
Once the user joins the app, they will be able to access the booth.

new booth view

mail

Registartion page after accepting link

After registration my booth option available

columns added to User

codecov · 2019-06-09T16:34:04Z

Codecov Report

Merging #2535 into GSoC19 will decrease coverage by 6.64%.
The diff coverage is 26.31%.

@@            Coverage Diff             @@
##           GSoC19    #2535      +/-   ##
==========================================
- Coverage   82.58%   75.94%   -6.65%     
==========================================
  Files         146      146              
  Lines        4767     4847      +80     
==========================================
- Hits         3937     3681     -256     
- Misses        830     1166     +336

Impacted Files	Coverage Δ
app/models/user.rb	`95% <100%> (+0.03%)`	⬆️
app/models/booth.rb	`88% <100%> (+0.24%)`	⬆️
app/controllers/application_controller.rb	`77.77% <100%> (+2.02%)`	⬆️
app/controllers/booths_controller.rb	`50% <12.5%> (-12%)`	⬇️
app/controllers/admin/booths_controller.rb	`50% <12.5%> (-8.34%)`	⬇️
app/controllers/tickets_controller.rb	`0% <0%> (-90%)`	⬇️
app/controllers/ticket_purchases_controller.rb	`0% <0%> (-77.28%)`	⬇️
app/controllers/admin/volunteers_controller.rb	`0% <0%> (-66.67%)`	⬇️
app/helpers/versions_helper.rb	`27.08% <0%> (-56.25%)`	⬇️
app/controllers/payments_controller.rb	`0% <0%> (-51.86%)`	⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6140688...98a57e0. Read the comment docs.

codecov · 2019-06-09T16:34:05Z

Codecov Report

Merging #2535 into GSoC19 will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           GSoC19    #2535     +/-   ##
=========================================
+ Coverage   82.21%   82.31%   +0.1%     
=========================================
  Files         146      147      +1     
  Lines        4773     4795     +22     
=========================================
+ Hits         3924     3947     +23     
+ Misses        849      848      -1

Impacted Files	Coverage Δ
app/models/user.rb	`94.96% <ø> (ø)`	⬆️
app/controllers/booths_controller.rb	`64.15% <100%> (+2.15%)`	⬆️
app/controllers/concerns/invitation.rb	`100% <100%> (ø)`
app/models/booth.rb	`88% <100%> (+0.24%)`	⬆️
app/controllers/admin/booths_controller.rb	`60% <100%> (+1.66%)`	⬆️
app/controllers/application_controller.rb	`77.77% <100%> (+2.02%)`	⬆️
app/controllers/commercials_controller.rb	`96.42% <0%> (+3.57%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12f10c7...29c15c5. Read the comment docs.

Gemfile

app/models/user.rb

app/controllers/admin/booths_controller.rb

spec/controllers/admin/booths_controller_spec.rb

Ana06 · 2019-06-12T16:07:33Z

@rahul2240 you also need to fix the lint offenses and tests (in general it is a good practice to run the test locally before sending the PR 😉)

rahul2240 · 2019-06-12T18:23:46Z

@rahul2240 you also need to fix the lint offenses and tests (in general it is a good practice to run the test locally before sending the PR )

@Ana06 I have 1 lint only for 105 lines used whose limit is 100, so can you tell me what i should do and i dont know what error is breaking the other tests as it is something related to Selenium::WebDriver::Error::UnknownError:
unknown error: Chrome failed to start: exited abnormally

so i send a PR to ask about it.

Ana06 · 2019-06-13T08:21:49Z

@rahul2240

so i send a PR to ask about it.

but you didn't ask 🤣 It is fine. Let's check if I can help you. 😉

@Ana06 I have 1 lint only for 105 lines used whose limit is 100, so can you tell me what i should do

When a class gets to big, it is normally because there are things on it that doesn't belong there. So, you need to split things out (moving model related logic to the models, using concerns, introduce new controllers, etc.). invite is currently in the User model, but it is not necessarily related to the user. It is maybe time to put everything related with the invitation (in both user model and booth controller) out and together.

and i dont know what error is breaking the other tests as it is something related to Selenium::WebDriver::Error::UnknownError:
unknown error: Chrome failed to start: exited abnormally

This is not related to your PR, it is failing in other PRs as well. We need to fix it, but not as part of this PR.

rahul2240 · 2019-06-13T08:31:12Z

@Ana06 I forgot to ask :P, Thanks for the help, For the upcoming work that I mentioned I am creating an invitation controller (for admins only) and model also to handle things related to model. But for booths I thought it would be better if I use invitation in booths controller itself as it is the only feature that user going to have, related to invitation.

differentreality · 2019-06-16T11:10:31Z

@rahul2240 let's discuss a bit what you are trying to accomplish. What's the plan?
I'd expect you to provide the workflow you are trying to implement in the PR description or the issue relevant to this particular feature and PR.

The following is more of a conversation starter than a final plan.

User submits booth request
User invites 2 people to become booth responsibles
Devise invitable creates 2 new user records, and sends invitation
The new user accounts are already associated with the booth request
(but in the end we should only associate real users with a Booth, at least upon acceptance)

app/controllers/booths_controller.rb

spec/factories/booths.rb

rahul2240 · 2019-06-16T19:51:41Z

@differentreality @Ana06 I have removed some commits to make this PR small and related to 1 thing only. I will create other PR for an unsubscribing link in the invitation email and customized invitation message.
Please review this PR again 😄

rahul2240 · 2019-06-16T20:02:42Z

@rahul2240 let's discuss a bit what you are trying to accomplish. What's the plan?
I'd expect you to provide the workflow you are trying to implement in the PR description or the issue relevant to this particular feature and PR.

The following is more of a conversation starter than a final plan.

User submits booth request

User invites 2 people to become booth responsibles

Devise invitable creates 2 new user records, and sends invitation

The new user accounts are already associated with the booth request
(but in the end we should only associate real users with a Booth, at least upon acceptance)

@differentreality User can invite any number of people. I can add minItem: 2 at the form to only allow 2 users to invite at a time.
I will work on associating only confirmed users with roles, booths, conferences in separate PR.

rahul2240 · 2019-06-17T07:09:52Z

app/controllers/application_controller.rb

@@ -9,6 +9,8 @@ class ApplicationController < ActionController::Base
  # Ensure every controller authorizes resource or skips authorization (skip_authorization_check)
  check_authorization unless: :devise_controller?

+  before_action :devise_configure_permitted_parameters, if: :devise_controller?


devise_parameter_sanitizer.permit(:accept_invitation, keys: [:username])

used to add username field in the registration page for invited users otherwise only password and password confirmation fields were present.

differentreality · 2019-06-20T12:32:42Z

Once the users will register to the app then they will be able to edit the booth for which they were invited.

How is this going to happen exactly?

In your steps you mention that you will create an unconfirmed user. How is this user going to be related to a booth?

rahul2240 · 2019-06-20T12:52:12Z

@differentreality unconfirmed user's id will be used to associate that user with the booth using

BoothRequest.create(booth_id: @booth.id, user_id: created_user.id,
                              role: 'responsible')

If a user registers then there is no problem.
If he doesn't, then invited user will not be visible to the booth owner in the responsibles field in edit booth page. This way booth owner will know that he needs other booth responsibles or reinvite the same user.
Only confirmed users are visible in the responsibles field for new or edit booth.

differentreality · 2019-06-20T13:01:25Z

app/helpers/invite_helper.rb

+
+      emails_array.each do |email|
+        new_user = User.find_by(email: email)
+        if new_user.nil? || !new_user.confirmed?


!new_user.confirmed? that's not bulletproof. It's possible that we have unconfirmed users (when using) but the users are actually able to log in and don't require invitation.

@differentreality we can add user's "last_sign_in_at", if it is nil then we can send invitations again, is that okay?

If there is already a user record, why do we need to check anything else?

I mean there are a few ways we can go with this approach and make the feature more useful and meaningful, but what is currently being implemented is pretty basic, so I don't think we should add any more functionality than what is absolutely necessary, unless you plan on documenting (and adding tests) for the more advanced scenarios.

@differentreality alright, for now, I will keep it simple but will work on improving it later in other PR.

app/helpers/invite_helper.rb

differentreality · 2019-07-21T10:13:03Z

@rahul2240 please rebase

The tests are not very thorough here :/ We should revisit them soon.

app/views/booths/_form.html.haml

rahul2240 · 2019-07-21T12:04:24Z

The tests are not very thorough here :/ We should revisit them soon.

Sure.

app/views/booths/_form.html.haml

It is added so that user can enter email ids of other users, who they want to invite to become booth responsible.

email validation and input as tags is added using selectize

Devise invitable gem is required to invite users.

User will enter email of users to invite to become booth responsible, which will create a user in User db with that email and a new booth request will be created.

differentreality · 2019-07-21T12:55:12Z

Only confirmed users are visible in the responsibles field for new or edit booth.

Where do you see that?

I was talking about active users
while adding booth responsibles in the booth, only active users are available in the list due to the condition
https://github.com/openSUSE/osem/blob/master/app/helpers/application_helper.rb#L135

This isn't right though! Active users used to be something completely different, and now they are the ones who logged in during the last 3 months.
This is the commit that changed the definition 516e53d

We need to actually get all active (as in not disabled) users for our selection field. Do you want to submit a PR for that in master, or should I?

differentreality · 2019-07-21T17:43:36Z

OK let's get this in as a starting point, and work on it a bit more later on to add more possibilities

see who has been invited
trigger re-invitation
maybe even undo a pending invitation (or actually remove the user as booth responsible?)

rahul2240 force-pushed the booth_invitation branch from 5b91899 to 98a57e0 Compare June 9, 2019 16:34

rahul2240 force-pushed the booth_invitation branch 3 times, most recently from 6a122c5 to f094553 Compare June 9, 2019 18:59

Ana06 requested changes Jun 12, 2019

View reviewed changes

differentreality reviewed Jun 16, 2019

View reviewed changes

app/controllers/booths_controller.rb Outdated Show resolved Hide resolved

differentreality reviewed Jun 16, 2019

View reviewed changes

spec/factories/booths.rb Outdated Show resolved Hide resolved

rahul2240 force-pushed the booth_invitation branch 5 times, most recently from 3873e20 to b17738f Compare June 16, 2019 19:44

rahul2240 force-pushed the booth_invitation branch 2 times, most recently from 0a8de7c to 5bf6d63 Compare June 16, 2019 20:56

This was referenced Jun 16, 2019

Unsubscribe link on the invitation email #2542

Closed

[WIP] Invite people with roles #2543

Closed

rahul2240 commented Jun 17, 2019

View reviewed changes

rahul2240 force-pushed the booth_invitation branch from 5bf6d63 to 9e1df67 Compare June 17, 2019 18:16

differentreality reviewed Jun 20, 2019

View reviewed changes

rahul2240 force-pushed the booth_invitation branch 11 times, most recently from 571fd76 to a1a7857 Compare July 20, 2019 09:36

rahul2240 force-pushed the booth_invitation branch 5 times, most recently from ef9ae35 to 0500a24 Compare July 21, 2019 11:15

differentreality reviewed Jul 21, 2019

View reviewed changes

app/views/booths/_form.html.haml Outdated Show resolved Hide resolved

rahul2240 force-pushed the booth_invitation branch from 0500a24 to 5bab917 Compare July 21, 2019 11:55

differentreality reviewed Jul 21, 2019

View reviewed changes

app/views/booths/_form.html.haml Outdated Show resolved Hide resolved

rahul2240 added 4 commits July 21, 2019 18:08

Add invite responsible to form

58c8295

It is added so that user can enter email ids of other users, who they want to invite to become booth responsible.

Add selectize to invite responsibles

a20c1bb

email validation and input as tags is added using selectize

Install devise invitable

04c3859

Devise invitable gem is required to invite users.

Booth invitation to invited users

29c15c5

User will enter email of users to invite to become booth responsible, which will create a user in User db with that email and a new booth request will be created.

rahul2240 force-pushed the booth_invitation branch from 5bab917 to 29c15c5 Compare July 21, 2019 12:38

hennevogel deployed to osem-demo-pr-2535 July 21, 2019 18:39 View deployment

differentreality merged commit 770a63e into openSUSE:GSoC19 Jul 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Invitation for booth responsibles #2535

Invitation for booth responsibles #2535

rahul2240 commented Jun 9, 2019 •

edited

Loading

codecov bot commented Jun 9, 2019

codecov bot commented Jun 9, 2019 •

edited

Loading

Ana06 commented Jun 12, 2019

rahul2240 commented Jun 12, 2019

Ana06 commented Jun 13, 2019

rahul2240 commented Jun 13, 2019

differentreality commented Jun 16, 2019

rahul2240 commented Jun 16, 2019

rahul2240 commented Jun 16, 2019 •

edited

Loading

rahul2240 Jun 17, 2019

differentreality commented Jun 20, 2019

rahul2240 commented Jun 20, 2019 •

edited

Loading

differentreality Jun 20, 2019

rahul2240 Jun 20, 2019

differentreality Jul 17, 2019

rahul2240 Jul 18, 2019

differentreality commented Jul 21, 2019

rahul2240 commented Jul 21, 2019 •

edited

Loading

differentreality commented Jul 21, 2019

differentreality commented Jul 21, 2019

Invitation for booth responsibles #2535

Invitation for booth responsibles #2535

Conversation

rahul2240 commented Jun 9, 2019 • edited Loading

codecov bot commented Jun 9, 2019

Codecov Report

codecov bot commented Jun 9, 2019 • edited Loading

Codecov Report

Ana06 commented Jun 12, 2019

rahul2240 commented Jun 12, 2019

Ana06 commented Jun 13, 2019

rahul2240 commented Jun 13, 2019

differentreality commented Jun 16, 2019

rahul2240 commented Jun 16, 2019

rahul2240 commented Jun 16, 2019 • edited Loading

rahul2240 Jun 17, 2019

Choose a reason for hiding this comment

differentreality commented Jun 20, 2019

rahul2240 commented Jun 20, 2019 • edited Loading

differentreality Jun 20, 2019

Choose a reason for hiding this comment

rahul2240 Jun 20, 2019

Choose a reason for hiding this comment

differentreality Jul 17, 2019

Choose a reason for hiding this comment

rahul2240 Jul 18, 2019

Choose a reason for hiding this comment

differentreality commented Jul 21, 2019

rahul2240 commented Jul 21, 2019 • edited Loading

differentreality commented Jul 21, 2019

differentreality commented Jul 21, 2019

rahul2240 commented Jun 9, 2019 •

edited

Loading

codecov bot commented Jun 9, 2019 •

edited

Loading

rahul2240 commented Jun 16, 2019 •

edited

Loading

rahul2240 commented Jun 20, 2019 •

edited

Loading

rahul2240 commented Jul 21, 2019 •

edited

Loading