Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies to production Docker image #2774

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

AndrewKvalheim
Copy link
Member

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the upstream master branch.
  • The tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works(if appropriate).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves

As of 6648082 the Docker base image no longer includes Bundler and Foreman:

@@ -25,11 +26,7 @@
 # Disable versioned gem binary names
 RUN echo 'install: --no-format-executable' >> /etc/gemrc
 
-# Install bundler & foreman
-RUN gem install bundler:1.17.3 foreman
-
 # Create our user
 RUN useradd -m --user-group osem

These dependencies are installed in the application image instead:

osem/Dockerfile

Lines 19 to 20 in 3c2a082

# Install bundler & foreman
RUN sudo gem install bundler:1.17.3 foreman

The production Dockerfile is missing them, causing its build to fail:

bundle: command not found

Changes proposed in this pull request

Add the dependencies to the production Dockerfile as well.

@AndrewKvalheim AndrewKvalheim changed the title Add missing dependencies to production Dockerfile Add missing dependencies to production Docker image Jun 18, 2021
Resolves:

    bundle: command not found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants