Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UserDatatable for ajax-datatables-rails 1 #2963

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

AndrewKvalheim
Copy link
Member

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the upstream master branch.
  • The tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves

UserDatatable hasn’t been migrated to ajax-datatables-rails v1 and fails to load data with NotImplementedError:

1) UserDatatable outputs recordsTotal
   Failure/Error: filter_records(fetch_records).unscope(:group, :select).count(:all)

   NotImplementedError:
     NotImplementedError
   # ./app/datatables/user_datatable.rb:59:in `records_filtered_count'
   # ./spec/datatables/user_datatable_spec.rb:95:in `block (3 levels) in <top (required)>'
   # ./spec/datatables/user_datatable_spec.rb:98:in `block (3 levels) in <top (required)>'

Changes proposed in this pull request

Update UserDatatable as RegistrationDatatable was in 81853d1.

Resolves failing test `spec/datatables/user_datatable_spec.rb:97`:

    1) UserDatatable outputs recordsTotal
       Failure/Error: filter_records(fetch_records).unscope(:group, :select).count(:all)

       NotImplementedError:
         NotImplementedError
       # ./app/datatables/user_datatable.rb:59:in `records_filtered_count'
       # ./spec/datatables/user_datatable_spec.rb:95:in `block (3 levels) in <top (required)>'
       # ./spec/datatables/user_datatable_spec.rb:98:in `block (3 levels) in <top (required)>'

Details: https://github.com/jbox-web/ajax-datatables-rails/blob/v1.3.1/doc/migrate.md#to-migrate-from-v04x-to-v100

RegistrationDatatable has already been updated in 81853d1.
@hennevogel hennevogel merged commit b04ad33 into openSUSE:master Mar 8, 2022
@AndrewKvalheim AndrewKvalheim deleted the ajax-datatables-rails-1 branch March 9, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants