-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openSUSE teample: add package name to sitelib path #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcepl
reviewed
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think?
sebix
force-pushed
the
opensuse-sitelib-path
branch
from
May 10, 2022 20:07
3f18649
to
1e2e2d6
Compare
Makes sense, thanks for the proposal |
mcepl
requested changes
May 10, 2022
sebix
force-pushed
the
opensuse-sitelib-path
branch
from
May 10, 2022 20:27
1e2e2d6
to
e7f1d93
Compare
the test fail does not seem related:
|
mcepl
reviewed
May 10, 2022
@sebix Could you please rebase here? Let’s see whether my other PR really helped. |
Submissions to devel:languages:python are not accepted if %{python_sitelib}/* is used, so add the name of the library to produce a default value which is permitted in openSUSE.
sebix
force-pushed
the
opensuse-sitelib-path
branch
from
May 11, 2022 09:15
e7f1d93
to
45b2bbb
Compare
Looks good - finally :) |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submissions to devel:languages:python are not accepted if
%{python_sitelib}/*
is used, so add the name of the library to produce a default value which
is permitted in openSUSE.