Remove redundant run_func from salt.master.MWorker._handle_aes #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhestkov
force-pushed
the
openSUSE/improve/3006.0/remove-redundant-run_func
branch
4 times, most recently
from
af9e7d9
to
0e130dd
Compare
3 tasks
vzhestkov
force-pushed
the
openSUSE/improve/3006.0/remove-redundant-run_func
branch
from
0e130dd
to
c8719f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Backport of saltstack/salt#66509 and saltstack/salt@0c3ebc0
Removes redundant useless call for
run_funcwhich seems introduced with saltstack/salt#48660It's not really clear if it could give any benefit here to have
run_funcused. Looks like it just adds extra stack entry on the call with no any benefit.What issues does this PR fix or reference?
Tracks: https://github.com/SUSE/spacewalk/issues/23526
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.