Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lease: add clone utils and reference counting #916

Merged
merged 4 commits into from
Jun 2, 2022

Conversation

mtomaschewski
Copy link
Member

No description provided.

mtomaschewski added a commit that referenced this pull request Jun 1, 2022
lease: add clone utils and reference counting
@mtomaschewski mtomaschewski self-assigned this Jun 1, 2022
Copy link
Collaborator

@cfconrad cfconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some small hints

include/wicked/refcount.h Outdated Show resolved Hide resolved
src/address.c Outdated Show resolved Hide resolved
src/netinfo.c Outdated Show resolved Hide resolved
include/wicked/refcount.h Outdated Show resolved Hide resolved
src/netinfo.c Outdated Show resolved Hide resolved
src/route.c Outdated Show resolved Hide resolved
src/route.c Outdated Show resolved Hide resolved
mtomaschewski and others added 4 commits June 2, 2022 12:36
Co-authored-by: Clemens Famulla-Conrad <cfamullaconrad@suse.de>
Added also rule array and route tables copy utils.
Renamed address_new to address_create like in route,
added also an ni_address_list_copy utility function.
mtomaschewski added a commit that referenced this pull request Jun 2, 2022
lease: add clone utils and reference counting
mtomaschewski added a commit that referenced this pull request Jun 2, 2022
lease: add clone utils and reference counting
Copy link
Collaborator

@cfconrad cfconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx!

@cfconrad cfconrad merged commit cff372a into openSUSE:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants