Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infinite while loop in TrainLoop.run_loop #59

Closed
tahaceritli opened this issue Jul 29, 2022 · 3 comments
Closed

infinite while loop in TrainLoop.run_loop #59

tahaceritli opened this issue Jul 29, 2022 · 3 comments

Comments

@tahaceritli
Copy link

Hi,

Thanks for sharing this repo!

I am trying to train the models from scratch. It seems that TrainLoop(...).run_loop() function has a while loop that is running on infinitely, as self.lr_anneal_steps is set 0. I'm referring to the code snippet given below:
while ( not self.lr_anneal_steps or self.step + self.resume_step < self.lr_anneal_steps ):

I suppose that it is safe to define a num_iterations parameter and use it in this loop? If so, I suppose this parameter is the one reported in Table 11-13 of the arXiv paper.

I would appreciate if you could clarify this.

Best,
Taha

@hxy-123-coder
Copy link

Hello!I have same question with you.Do you solve it? Could you share your solution?Thanks a lot.

@tahaceritli
Copy link
Author

I have just defined a separate variable for the number of iterations and checked if self.step is lower than that, like:

num_iterations = 600000
while self.step < num_iterations:
...

I haven't tried to reproduce the tables in the paper though.

@hxy-123-coder
Copy link

Ok,Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants