marekhorst #37 exporter module serializing actions to json #57
Conversation
…ageAction support from ActionManagerServiceFacade API since XsltInfoPackageAction provides asAtomicActions() method
…files: * introducing SequenceFileExporterMapper and updating exporter processes to handle exporting actions encoded as jsons into sequence file * introducing sequence file exporter workflow definition and enabling sequence file export mode in both primary and preprocessing workflows, adding distcp phase * renaming active_export_to_hbase flag to active_export_to_actionmanager
|
I think that we should stick to the convention that the pull request should be named the same as the commit corresponding to this request and the commit itself should have a form of "Closes #$ISSUE_NUMBER". |
|
I'm done with the review, please take a look. |
|
One more thing: we should have some tests covering this functionality. |
|
Regarding the tests: I am all for it. This will take some time, so I will suggest creating separate issue for this task. |
|
I've just pushed bunch of fixes requested in comments. |
Agree. Taking into consideration that we've got a lot of close deadlines upon us, this is the only option. I think that in the future, the tests should be a standard part of pull requests. |
|
I'm done with answering, please take a look. |
|
Sure. I've created #73 ticket to track test related task. |
|
I've just committed lighter version of |
|
Still, at ~50 lines not exactly a short method, but more readable. Looks good to me. |
marekhorst
deleted the
marekhorst_#1522_exporter_module_serializing_actions_to_JSON
branch
This feature is related to new CDH5->CDH4 compatible exporter module writing actionsets as sequence files with JSON records instead of exporting them directly as protobufs to HBase.
More details can be found in #37 issue.
Please review.