Two small fixes to enable reconnecting and prevent forked process from hanging at 100% cpu #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug in handle_info prevent latest iOS to connect
Catalina came with Python2. Updated instructions to include installing python3 and using it with virtualenv
Fixes reconnect issue Fixes 100% CPU usage after disconnect issue
|
@PaulWieland: Applied, thanks! |
glmnet
reviewed
Jul 9, 2021
| self.server.hap = None | ||
|
|
||
| # terminate the forked event_proc, otherwise a zombie process consumes 100% cpu | ||
| self.event_proc.terminate() |
There was a problem hiding this comment.
This seems to cause the tcp connection to be closed. Hence when skipping a track forward airplay disconnects.
There was a problem hiding this comment.
Well, hanging processes seem worse than disconnects at fast forward. But this is a good find. Do your instincts have any proposals about how to reconcile the CPU fix and a disconnect fix?
|
@systemcrash: Have you seen the @glmnet comment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.