-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPS uses meter BG to determine glucose value (null) #1265
Comments
This should only occur if your meter uploads Also, it will only result in That said, if you'd like to test a fix for this, I just pushed https://github.com/openaps/oref0/tree/ignore-glucose-null - if you can confirm that it allows looping off the last CGM reading even when there's a more recent MBG record, we can open a PR to merge it to dev. |
@PaperT1D which uploader application do you use? This should be fixed in the uploader (and I'd love to know so I can add better data checking to Nightscout). @scottleibrand feel free to tag me in any Nightscout data quality tickets going forward if I don't notice them |
I am using xDrip+ and a Contour Next One meter, which is Bluetooth connected to automatically add meter BG entries to xDrip. While mbg had a value, it showed I will give the fix a test in the next day or two. Thanks! |
@PaperT1D did you get around to testing this? |
Working on getting it installed in just a few minutes. Hopefully let you
know soon.
…On Sun, Oct 20, 2019 at 7:29 PM Dana Lewis ***@***.***> wrote:
@PaperT1D <https://github.com/PaperT1D> did you get around to testing
this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1265?email_source=notifications&email_token=AJJLNBMTVO2EPIFYE5U7S23QPTZXXA5CNFSM4HRSAZ72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBYX6ZA#issuecomment-544309092>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJJLNBOD3QY2XEZEVHJCFHDQPTZXXANCNFSM4HRSAZ7Q>
.
|
Well, it looks like this didn't fix it. The
|
Opened a PR to fix this issue: #1328 I added a test to replicate your scenario, and the fix seems to work. I'll run it on my rig in the meantime to catch any potential regression. |
Describe the bug
OpenAPS ignores current CGM glucose and instead takes glucose from a recent Nightscout meter BG entry and returns
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I don't think the loop should be taking Nightscout non-calibration meter BG entries into consideration for looping.
Setup Information (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: