Advanced meal assist #125
Advanced meal assist #125
Conversation
…advanced-meal-assist
* A couple more temp basal IOB tests; lib/iob/history.js is now pretty well covered * Configurable safety limits pass 1, with tests * Added --update-preferences and --export-defaults options to oref0-get-profile
…advanced-meal-assist
Fixing merge ama
…code for the inputs to be read in
* Change from json -e to json -E for speedup * Some more BG conversions in determine-basal output
Add model_data to profile, fix usage string
Merge dev into ama via merge-ama branch
|
Checks are now passing, so this is a candidate for merge if no one flags any issues. I believe @cjo20 said things looked good for him. Anything else we need to do before merging to dev? |
|
Yup, things looked good for me when I upgraded. I'm not sure if the reordering of the yargs stuff in oref0-get-profile has introduced any upgrade problems, but it should be minor |
|
Yeah, I'm not too worried about anything that only affects people who've added a feature in the last week or two. :-) |
|
One last call for any objections to merging AMA to dev. |
| @@ -105,7 +106,7 @@ if (!module.parent) { | |||
| console.error(msg.msg); | |||
| // console.log(JSON.stringify(msg)); | |||
| if (!params['missing-meal-ok']) { | |||
| errors.push(msg); | |||
| warnings.push(msg); | |||
There was a problem hiding this comment.
FWIW, --no-missing-meal-ok means "strict" mode which I would prefer throw an error (since it's being asked for).
There was a problem hiding this comment.
If you'd like a flag for strict mode that's fine, but the default needs to be to warn, not break the loop. This has caused us issues several times due to network comms issues (like wifi captive portals) when configuration is fine.
There was a problem hiding this comment.
for interactive/manual mode strict is nice, since it will help spot issues, but when running a loop it's a problem
I added --missing-meal-ok to my rigs to prevent issues, but I expect others to miss that and have their loop fail.
|
Left a few notes regarding tips on maintaining positional arguments vs option switches over the long haul. Overall I'm excited to get this into dev and subsequently do a release. |
|
Sounds like we should merge to dev and then do some additional yargs conversion (in addition to the stuff that has recently been added) before releasing to master. If no objections, I'll do the merge to dev today. |
|
I'd be ok requiring the |
Dev pathway for ama happens here.