Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WDAError : class chain did not add escape character for ' or " #33

Closed
lukzeg opened this issue Sep 12, 2017 · 3 comments
Closed

WDAError : class chain did not add escape character for ' or " #33

lukzeg opened this issue Sep 12, 2017 · 3 comments

Comments

@lukzeg
Copy link
Contributor

lukzeg commented Sep 12, 2017

If we will will want to get objects with ' or " character we observe WDAError(status 13):
session(text="don't")

I think in line 600:
https://github.com/openatx/facebook-wda/blob/master/wda/__init__.py

It should be added some method which will add "" before ' or " to avoid of having issue with parsing when chain is created(line:672), as we might to catch situation:
"name == 'I don't want'"
which is causing mentioned by me error.
Tested on WebDriverAgent - a10768631110f4b7c2d7ca328a9f11186464ae35

@codeskyblue
Copy link
Member

Maybe need string escape

lukzeg pushed a commit to lukzeg/facebook-wda that referenced this issue Oct 17, 2017
@lukzeg
Copy link
Contributor Author

lukzeg commented Oct 17, 2017

I created pull request with fix for this issue.
#36

@codeskyblue
Copy link
Member

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants