Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3: update base vault images to point at quay.io/openbao/openbao; add more helm docs #8

Merged
merged 4 commits into from
May 20, 2024

Conversation

jessebot
Copy link

@jessebot jessebot commented May 18, 2024

Changes

  • updates references to hashicorp/vault to openbao/openbao (and sets their tags to the latest on quay.io)
  • adds image.registry to several all the image maps so we can use quay.io for right now, and other users can use their own personal registries of choice
  • changes more comments to start with # -- so that helm-docs picks them up to generate the README.md parameters table (though not all of them, as we can do a differnet PR for a FULL doc pass)
  • fix a bunch of comments that didn't have spaces after the # so that the linter would calm down

Caveats

This only partially addresses #3 because the following images do not have openbao equivalents yet:

  • hashicorp/vault-csi-provider <-- needs it's official repo forked (use commit before hashicorp/vault-csi-provider@9910eb3)
  • hashicorp/vault-k8s <-- not sure if this is available, have to hunt it down 🤷

I vote we still move this forward, albeit after #7 is merged so that we can verify the tests are working. We can always do another PR to tackle the final two images that are referenced from hashicorp.

EDIT: #7 (comment) explains alternative ways of merging both changes from #7 and this PR :)

@jessebot
Copy link
Author

note: I went off on a whole tangent in #7 (comment) to explain what's going to happen with the linter and how we can solve it :)

@jessebot jessebot changed the title update base vault images to point at quay.io/openbao/openbao; add more helm docs Issue 3: update base vault images to point at quay.io/openbao/openbao; add more helm docs May 20, 2024
@naphelps
Copy link
Member

Pulled in openbao-csi-provider.

@naphelps naphelps self-requested a review May 20, 2024 21:06
@naphelps naphelps merged commit 7ad371f into openbao:main May 20, 2024
1 of 2 checks passed
@jessebot jessebot deleted the issue-3 branch May 20, 2024 21:44
@jessebot jessebot mentioned this pull request May 20, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants