Issue 3: update base vault images to point at quay.io/openbao/openbao; add more helm docs #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
hashicorp/vault
toopenbao/openbao
(and sets their tags to the latest on quay.io)image.registry
to several all the image maps so we can usequay.io
for right now, and other users can use their own personal registries of choice# --
so that helm-docs picks them up to generate theREADME.md
parameters table (though not all of them, as we can do a differnet PR for a FULL doc pass)#
so that the linter would calm downCaveats
This only partially addresses #3 because the following images do not have openbao equivalents yet:
I vote we still move this forward, albeit after #7 is merged so that we can verify the tests are working. We can always do another PR to tackle the final two images that are referenced from hashicorp.
EDIT: #7 (comment) explains alternative ways of merging both changes from #7 and this PR :)