Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid invoking token helper on login #313

Merged
merged 2 commits into from
May 3, 2024
Merged

Avoid invoking token helper on login #313

merged 2 commits into from
May 3, 2024

Commits on May 3, 2024

  1. Avoid invoking token helper on login 

    `bao login` used to call the token helper in `get` mode, because it
constructs an HTTP client, and the client automatically loads the token.
For almost everything that is the right thing to do, but for login, that
is the thing that is supposed to retrieve the token, and login itself
does not require the token. In fact, `bao login` would erase the token
on the client later on.

Calling the token helper in `get` mode is a problem, because if the
token helper fails, that blocks the login. But the token helper might
fail because it doesn't have a token yet.

This fixes openbao#312.

Signed-off-by: Ruud van Asseldonk <ruud@chorus.one>
    @ruuda @naphelps
    ruuda authored and naphelps committed May 3, 2024
    Configuration menu
    Copy the full SHA
    163885b View commit details
    Browse the repository at this point in the history

  2. Add changelog entry for openbao#313 

    Signed-off-by: Ruud van Asseldonk <ruud@chorus.one>
    @ruuda @naphelps
    ruuda authored and naphelps committed May 3, 2024
    Configuration menu
    Copy the full SHA
    adc5226 View commit details
    Browse the repository at this point in the history