Allow setting KeyUsage, ExtKeyUsage on CAs #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
add-eku-to-issuer-apis
branch
from
f82939b
to
c6d487b
Compare
This adds the ability to set KeyUsage and ExtKeyUsage on roots and intermediates created in OpenBao. This does not add the ability to add KeyUsage or ExtKeyUsage extensions to intermediate CA CSRs as that can be added by the signing CA conditionally. This allows interoperability with GCP Load Balancers and compiles with CA/BF guidelines. Only DigitalSignature may (optionally) be added to KeyUsage, but no restrictions are placed on ExtKeyUsage or its OIDs. Resolves: openbao#60 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
add-eku-to-issuer-apis
branch
from
c6d487b
to
95c2194
Compare
naphelps
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to set KeyUsage and ExtKeyUsage on roots and intermediates created in OpenBao. This does not add the ability to add KeyUsage or ExtKeyUsage extensions to intermediate CA CSRs as that can be added by the signing CA conditionally.
This allows interoperability with GCP Load Balancers and compiles with CA/BF guidelines. Only DigitalSignature may (optionally) be added to KeyUsage, but no restrictions are placed on ExtKeyUsage or its OIDs.
Resolves: #60