Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning fixes #45

Merged
merged 7 commits into from
Dec 1, 2015
Merged

Warning fixes #45

merged 7 commits into from
Dec 1, 2015

Conversation

shenki
Copy link
Member

@shenki shenki commented Nov 25, 2015

One real bug, a bunch of unused variables and a missing header.

Signed-off-by: Joel Stanley <joel@jms.id.au>
Wrap the entire header in an ifdef'd extern "C" so it can be used from C
files.  This fixes compilation for c files that need the header.

Signed-off-by: Joel Stanley <joel@jms.id.au>
Needed for a prototype for ipmid_get_sd_bus_connection.

Signed-off-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Joel Stanley <joel@jms.id.au>
apphandler.C:188:24: warning: array subscript is above array bounds [-Warray-bounds]
             tmp_array[3] = '\0';
                        ^

Initalise tmp_array to zero, and avoid this bad access.

Signed-off-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Joel Stanley <joel@jms.id.au>
@causten
Copy link
Member

causten commented Nov 25, 2015

I have review these changes and approve

nkskjames added a commit that referenced this pull request Dec 1, 2015
@nkskjames nkskjames merged commit ec64f28 into openbmc:master Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants