scan-build: objects/pflash/libflash/libflash.c:571,2 Undefined or garbage value returned to caller

[amboar]

546 int flash_force_4b_mode(struct flash_chip *c, bool enable_4b)
547 {
548     struct spi_flash_ctrl *ct = c->ctrl;
549     int rc;

1   'rc' declared without an initial value  →
550 
551     /*
552      * We only allow force 4b if both controller and flash do 4b
553      * as this is mainly used if a 3rd party tries to directly
554      * access a direct mapped read region
555      */
556     if (enable_4b && !((c->info.flags & FL_CAN_4B) && ct->set_4b))
557         return FLASH_ERR_4B_NOT_SUPPORTED;
558 
559     /* Only send to flash directly on controllers that implement
560      * the low level callbacks
561      */
562     if (ct->cmd_wr) {

2 ←   Taking false branch →
563         rc = flash_set_4b(c, enable_4b);
564         if (rc)
565             return rc;
566     }
567 
568     /* Then inform the controller */
569     if (ct->set_4b)

3 ←   Taking false branch →
570         rc = ct->set_4b(ct, enable_4b);
571     return rc;

4 ←   Undefined or garbage value returned to caller
572 }

[williamspatrick]

This code should be deprecated per #19 .

[williamspatrick]

@amboar - Has this been fixed in upstream pflash?

[amboar]

@williamspatrick I haven't checked, but I plan to

[amboar]

@williamspatrick looks to be fixed in skiboot/libflash:

int flash_force_4b_mode(struct flash_chip *c, bool enable_4b)
{
    struct spi_flash_ctrl *ct = c->ctrl;
    int rc = FLASH_ERR_4B_NOT_SUPPORTED;
    ...

[williamspatrick]

Fixed.

[williamspatrick]

(by removal of pflash)